From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 008A038493CA for ; Mon, 13 Feb 2023 14:18:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 008A038493CA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 6800C100478C6 for ; Mon, 13 Feb 2023 14:18:01 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id RZebppNCxBkq3RZebpzuc2; Mon, 13 Feb 2023 14:18:01 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DdHSFthW c=1 sm=1 tr=0 ts=63ea4699 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=RrxEXUcQQ5WVE7srb80A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ptI1oqJ7cHop7cLNuPln4LiHaJrfL14rN/mRw6XRx/8=; b=ne/ARVZDvYueqtlI3FiVgZL2d2 U1GXEgiA2dxp/SkcuC85L9nk1/7fjohHAI7LQ4KbSGEzMLLNXBL41GLKzmjfM6hgvZi62iN6yCAzb N3tty091G5Fw6Z/JMCC+DQgIQ; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:49892 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pRZeb-0026Lr-4v; Mon, 13 Feb 2023 07:18:01 -0700 From: Tom Tromey To: Aaron Merey via Gdb-patches Cc: Tom Tromey , Aaron Merey Subject: Re: [PATCH] gdb/debuginfod: Prevent prompt for continue during downloading. References: <20230128040601.2927632-1-amerey@redhat.com> <87a622itys.fsf@tromey.com> <87edran5qf.fsf@tromey.com> <87a61omd35.fsf@tromey.com> X-Attribution: Tom Date: Mon, 13 Feb 2023 07:17:59 -0700 In-Reply-To: (Aaron Merey via Gdb-patches's message of "Fri, 10 Feb 2023 21:02:19 -0500") Message-ID: <871qmtwsx4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pRZeb-0026Lr-4v X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:49892 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Aaron" == Aaron Merey via Gdb-patches writes: Aaron> However the on-demand downloading work creates new situations where Aaron> a large series of downloads might happen outside fetch_inferior_event. Aaron> For example, "break client.c:50" could download the .debug_line and Aaron> .debug_line_str of each shared library to search for the filename Aaron> "client.c". Then it downloads debuginfo for each match, all of which Aaron> happens outside of fetch_inferior_event. Aaron> Setting pagination_enabled=false in debuginfod_*_query prevents the Aaron> prompt durings the downloads but lines_printed keeps increasing. Aaron> If lines_allowed is exceeded then after the download you get an (IMO) Aaron> annoying prompt: I think this is what the user has requested, though. The pager can easily be disabled, but if we let code work around it, there's not really any way to ask for it to be enabled again. Aaron> Adding a count_lines_printed flag gives us another way to fine-tune Aaron> when the prompt shows up. It keeps prompt behavior around debuginfod Aaron> output consistent whether or not the inferior is running. This is an internal distinction but it seems to me that to the user, gdb output is just gdb output and can't really be differentiated by its origin. Tom