From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id ACC693858D38 for ; Fri, 14 Oct 2022 18:39:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ACC693858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id B8D8410041C84 for ; Fri, 14 Oct 2022 18:39:44 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id jPayoswPQjpD5jPayoJ3vf; Fri, 14 Oct 2022 18:39:44 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=T8NJ89GQ c=1 sm=1 tr=0 ts=6349acf0 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=17Aa-1aCIJoWveH35p8A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2V3C++yS7KGeZiI4rUKnHqCFncrteGLDS0y5p3uKRZg=; b=QG7bhCL9MaLIsT5xoKOVTWNNoL cocsDv5GljjeJ2L4d8K6q+CnnZ4JrrYulVtV0YCNLnuNroxmVQXnZUP+vWxwodStrZIzUHdFUYdRP qugNfNHWBmaT7tmMk6zp+ZXeG; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:56690 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ojPax-000XMo-DG; Fri, 14 Oct 2022 12:39:43 -0600 From: Tom Tromey To: Tsukasa OI via Gdb-patches Subject: Re: [RFC PATCH 1/1] gdb/riscv: Cache per-BFD disassembler References: <760e2c443b1244b2a0a64f7f865e905b9ef90a72.1665287884.git.research_trasio@irq.a4lg.com> X-Attribution: Tom Date: Fri, 14 Oct 2022 12:39:37 -0600 In-Reply-To: <760e2c443b1244b2a0a64f7f865e905b9ef90a72.1665287884.git.research_trasio@irq.a4lg.com> (Tsukasa OI via Gdb-patches's message of "Sun, 9 Oct 2022 03:59:03 +0000") Message-ID: <871qrameqe.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1ojPax-000XMo-DG X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (murgatroyd) [71.211.160.49]:56690 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2022 18:39:57 -0000 >>>>> Tsukasa OI via Gdb-patches writes: > +static int > +riscv_print_insn (bfd_vma memaddr, disassemble_info *info) > +{ > + static disassembler_ftype disassemble_fn = NULL; > + static bfd *abfd = NULL; This seems mildly dangerous, in that a BFD could be destroyed, then a new one created with the same address. It's better to cache things using the registry system. See gdb/registry.h. You can look for "registry" for examples. Tom