From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id D811B3858C83 for ; Sun, 21 Aug 2022 14:02:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D811B3858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id CB060100AEE19 for ; Sun, 21 Aug 2022 14:01:58 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id PlWYos7kYCokGPlWYosSpp; Sun, 21 Aug 2022 14:01:58 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=c8Nu/Txl c=1 sm=1 tr=0 ts=63023ad6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=biHskzXt2R4A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=PkHVCJjU_poKnyaO0JoA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RFPr0q3NhmD5ZXWXn5AwIyMpDmvg7mjLX+0EmPmqqYc=; b=Qd0xJBcf/A9c+jRcKV9/tpWT/D gKsXcdlFr/123exHyryF2kzcyYnYO7QTX3Wn0xL+tRrGyhxT6/W0W1pRVovDDqMxArnh5823IpoGf 3zVZe7lEXSMitKHFdLrYNoK+F; Received: from 71-211-185-105.hlrn.qwest.net ([71.211.185.105]:35564 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oPlWY-000xZb-3y; Sun, 21 Aug 2022 08:01:58 -0600 From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix crash in gdbpy_parse_register_id References: <20220427212742.4003557-1-tom@tromey.com> <80873420-8a71-111f-453c-f354381e0ad3@simark.ca> <87czff14og.fsf@tromey.com> X-Attribution: Tom Date: Sun, 21 Aug 2022 08:01:57 -0600 In-Reply-To: <87czff14og.fsf@tromey.com> (Tom Tromey's message of "Sat, 11 Jun 2022 11:38:23 -0600") Message-ID: <871qt9vgoa.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.105 X-Source-L: No X-Exim-ID: 1oPlWY-000xZb-3y X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-105.hlrn.qwest.net (prentzel) [71.211.185.105]:35564 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Aug 2022 14:02:12 -0000 [...] Tom> I did this. Tom> New patch appended. Tom> Fix crash in gdbpy_parse_register_id Tom> I noticed that gdbpy_parse_register_id would assert if passed a Python Tom> object of a type it was not expecting. The included test case shows Tom> this crash. This patch fixes the problem and also changes Tom> gdbpy_parse_register_id to be more "Python-like" -- it always ensures Tom> the Python error is set when it fails, and the callers now simply Tom> propagate the existing exception. I'm checking this in now. Tom