From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C4424386F0CC for ; Fri, 24 Jun 2022 15:09:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C4424386F0CC Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-331-RlPD0XdkP4eTeKyKINyzqA-1; Fri, 24 Jun 2022 11:09:37 -0400 X-MC-Unique: RlPD0XdkP4eTeKyKINyzqA-1 Received: by mail-wm1-f72.google.com with SMTP id ay28-20020a05600c1e1c00b0039c5cbe76c1so3198479wmb.1 for ; Fri, 24 Jun 2022 08:09:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=/YJhi1S1/JWFOqpYL/CuQx2aopGoxsKx+oX9PGewVlY=; b=ySVt2xF8Hp96OcPBX+LhaGdpZGkp7WaQDx6G2ygvlQyFUQ4FUbNimDiiAaGLw51mOe dqPFC1frMCf+AEuf4HtHJ0FkX530AYOo2k1Sa0THm2u2bkxMVzb0zh+amGQ3Ww8egUQ5 HhnRg2pq5WM7xIYFUH1PcX8zfsc0OV/PFb42aj+UVdcJqb8oFU5zx4UdtXLBpNLqVlaX sThmllhDhHrCNsYAH+M9Tqg5PbzMSUhv4xLDZKKwdftYiIAHu/g9GMefaz+EPbtiRCZM LQ0uuA8HekrLzBz16M9xpcE1H+v5uVZMaZ0EqqClKTfNVl6Ra6EZp/SlEVp8S7istIhD WTww== X-Gm-Message-State: AJIora8rlEG/IgEOWyRHONKzg7nxqgHZuu0k/ADiBX7cwwE27P71EHAd MgAFKgQDyVWt1ojMYzFlPaOefaB45cWt21AbKf1Cf6ANivyNE2ayaflOm15msP/3BYsq1E5EJ0k NrYB3tFx4Glzuvsx1tVL7aw== X-Received: by 2002:adf:fd92:0:b0:21a:3d15:91f9 with SMTP id d18-20020adffd92000000b0021a3d1591f9mr13523176wrr.262.1656083376265; Fri, 24 Jun 2022 08:09:36 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vUdsXC6I7Q24C9KOJuv+lPjil2Kwf71ZETNPrrg+WYy5d5mS4N/r2SNmYWwDRlapapq0NkmA== X-Received: by 2002:adf:fd92:0:b0:21a:3d15:91f9 with SMTP id d18-20020adffd92000000b0021a3d1591f9mr13523154wrr.262.1656083376018; Fri, 24 Jun 2022 08:09:36 -0700 (PDT) Received: from localhost ([195.213.152.79]) by smtp.gmail.com with ESMTPSA id f17-20020a7bcd11000000b0039c811077d3sm3026933wmj.22.2022.06.24.08.09.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 08:09:35 -0700 (PDT) From: Andrew Burgess To: "Maciej W. Rozycki" , gdb-patches@sourceware.org Cc: Simon Sobisch , Tom Tromey Subject: Re: [PATCH v5 4/8] GDB/testsuite: Tighten `set print elements' error check In-Reply-To: References: Date: Fri, 24 Jun 2022 16:09:34 +0100 Message-ID: <871qveayj5.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 15:09:40 -0000 "Maciej W. Rozycki" writes: > Match the whole error message expected to be given rather than omitting > the part about the "unlimited" keyword. There's no point in omitting > the missing part first, and second with an upcoming change the part in > parentheses will no longer be a fixed string, so doing a full match will > ensure the algorithm correctly builds the message expected here. Also > avoid any wildcard matches. LGTM. Thanks, Andrew > --- > No change from v4. > > New change in v4. > --- > gdb/testsuite/gdb.base/default.exp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > gdb-test-set-print-elements-tightening.diff > Index: src/gdb/testsuite/gdb.base/default.exp > =================================================================== > --- src.orig/gdb/testsuite/gdb.base/default.exp > +++ src/gdb/testsuite/gdb.base/default.exp > @@ -525,7 +525,8 @@ gdb_test_no_output "set print asm-demang > #test set print demangle > gdb_test_no_output "set print demangle" "set print demangle" > #test set print elements > -gdb_test "set print elements" "Argument required .integer to set it to.*" > +gdb_test "set print elements" \ > + "Argument required \\(integer to set it to, or \"unlimited\"\\)\\." > #test set print object > gdb_test_no_output "set print object" "set print object" > #test set print pretty