From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy4-pub.mail.unifiedlayer.com (qproxy4-pub.mail.unifiedlayer.com [66.147.248.250]) by sourceware.org (Postfix) with ESMTPS id 688D43AA842D for ; Fri, 27 May 2022 13:35:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 688D43AA842D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by qproxy4.mail.unifiedlayer.com (Postfix) with ESMTP id 432AE8032CF2 for ; Fri, 27 May 2022 13:35:17 +0000 (UTC) Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 07C0510045FC6 for ; Fri, 27 May 2022 13:34:47 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id ua74nAAXpY8ycua74nhg3C; Fri, 27 May 2022 13:34:47 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=ef34w5IH c=1 sm=1 tr=0 ts=6290d377 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=oZkIemNP1mAA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=QQ6Hp_oJbtQV7TE-5jMA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=P8T/L99VZWc4aRUWTa9VJo361+2eHWDOm0xIrJfBnXQ=; b=dT6ehpmINoR6VZ169DhpENlfIo x7mOB/bLlJBzO5gp1WApCTnlOqbGCfXfFk8Vd7GE4GyoQYGaZvWTxmVP7yPHvsClTRTbjGscTIdcV OuP7c4fpFC2DLeCY29iV0S1rF; Received: from 71-211-158-194.hlrn.qwest.net ([71.211.158.194]:55858 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nua74-001vjK-Dg; Fri, 27 May 2022 07:34:46 -0600 From: Tom Tromey To: Luis Machado via Gdb-patches Cc: Tom Tromey , Luis Machado Subject: Re: [PATCH] Fix crash with "maintenance print arc" References: <20220427100753.364631-1-luis.machado@arm.com> <87h76dmdp9.fsf@tromey.com> <06f43b22-c740-860b-1c75-9a00dcff12da@arm.com> X-Attribution: Tom Date: Fri, 27 May 2022 07:34:45 -0600 In-Reply-To: <06f43b22-c740-860b-1c75-9a00dcff12da@arm.com> (Luis Machado via Gdb-patches's message of "Thu, 5 May 2022 10:31:09 +0100") Message-ID: <871qwf6qve.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.158.194 X-Source-L: No X-Exim-ID: 1nua74-001vjK-Dg X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-158-194.hlrn.qwest.net (murgatroyd) [71.211.158.194]:55858 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2022 13:35:19 -0000 >>>>> "Luis" == Luis Machado via Gdb-patches writes: >> - add_show_prefix_cmd ("arc", class_maintenance, >> - _("ARC-specific maintenance commands for printing GDB " >> - "internal state."), >> - &maintenance_print_arc_list, >> - 0, &maintenanceprintlist); >> + add_basic_prefix_cmd ("arc", class_maintenance, >> + _("ARC-specific maintenance commands for printing GDB " >> + "internal state."), >> + &maintenance_print_arc_list, >> + 0, &maintenanceprintlist); >> add_cmd ("arc-instruction", class_maintenance, >> dump_arc_instruction_command, Luis> FTR, I'm happy to go with your patch for this one. Oops, I dropped this. I will check it in shortly. Tom