From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 1A1C238337AC for ; Sat, 21 May 2022 01:07:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1A1C238337AC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 822AB10048165 for ; Sat, 21 May 2022 01:07:36 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id sDain6DTfj8kTsDain9OdZ; Sat, 21 May 2022 01:07:36 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=MbSpB7zf c=1 sm=1 tr=0 ts=62883b58 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=oZkIemNP1mAA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=zd2uoN0lAAAA:8 a=ZU1ZcDde90YC2UiweAEA:9 a=QEXdDO2ut3YA:10:nop_charset_2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=d50ctoC6akhPrATjzMqkAhSq14kl9OhdKYsB8cHBymY=; b=mU0Y8FfUvRZw7OtyNfQjGJ/t/R 8VIKuYaYiojnT9T2Y1B5133GZm1GxdV3yBH5BtzywQyCqWwHhawod2cMoSButv7Hi1IlhCGzcw5U6 BFQ4NXCLbSMpxRhDMMbZCHMSq; Received: from 71-211-158-194.hlrn.qwest.net ([71.211.158.194]:34926 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nsDah-002cdY-NT; Fri, 20 May 2022 19:07:35 -0600 From: Tom Tromey To: Lancelot SIX Cc: Tom Tromey , Lancelot SIX via Gdb-patches , lsix@lancelotsix.com Subject: Re: [PATCH v2 1/2] gdb: Require psymtab before calling quick_functions in objfile References: <20220519184557.2169347-1-lancelot.six@amd.com> <20220519184557.2169347-2-lancelot.six@amd.com> <87k0agb3tn.fsf@tromey.com> <0db126be-7d03-d8ec-c825-a8dbd3d4ce72@amd.com> X-Attribution: Tom Date: Fri, 20 May 2022 19:07:34 -0600 In-Reply-To: <0db126be-7d03-d8ec-c825-a8dbd3d4ce72@amd.com> (Lancelot SIX's message of "Sat, 21 May 2022 00:07:06 +0100") Message-ID: <871qwng0bt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.158.194 X-Source-L: No X-Exim-ID: 1nsDah-002cdY-NT X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-158-194.hlrn.qwest.net (prentzel) [71.211.158.194]:34926 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 May 2022 01:07:38 -0000 >>>>> "Lancelot" =3D=3D Lancelot SIX writes: Lancelot> I have changed the declaration locally as follows (I did some bac= k and Lancelot> forth on whether it should stay grouped with the other methods of= =20 Lancelot> ojbfile bracketed between a pritave:/public: pair or if it should= go Lancelot> in a private section at the end of the struct =E2=80=94 I finally= opted for Lancelot> former). Yeah, objfile is a bit messy, someday we can try to clean it up. I think what you did is fine. Tom