From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id B668E3858D1E for ; Thu, 28 Apr 2022 02:11:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B668E3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id BAD1810047C33 for ; Thu, 28 Apr 2022 02:11:11 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id jtcdnWIPhY8ycjtcdn5vl8; Thu, 28 Apr 2022 02:11:11 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=TZJTCTch c=1 sm=1 tr=0 ts=6269f7bf a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=z0gMJWrwH1QA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=utMFRpPhdpyOUXSw24sA:9 a=M91JV_wKSCcA:10:nop_sms_unsolicited DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RgCzeu9y5B84Mcje/FfqV81gq3Bp7cVVa4bpbCHUAt8=; b=idPcuTYiTt4INxDZqMXIQB3MUl fKiDLARmMp8Psgu4kVFKqrTuD/a5801ueHd4syIKbQxaz6soolFR2AGdJL8tQcvPJDGthX3CUMqsu gIjNUA+HXU5oEGRaNQMzY1JbG; Received: from 71-211-158-194.hlrn.qwest.net ([71.211.158.194]:34634 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1njtcc-004JbH-Q1; Wed, 27 Apr 2022 20:11:10 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix crash in gdbpy_parse_register_id References: <20220427212742.4003557-1-tom@tromey.com> <80873420-8a71-111f-453c-f354381e0ad3@simark.ca> X-Attribution: Tom Date: Wed, 27 Apr 2022 20:11:10 -0600 In-Reply-To: <80873420-8a71-111f-453c-f354381e0ad3@simark.ca> (Simon Marchi's message of "Wed, 27 Apr 2022 21:45:42 -0400") Message-ID: <871qxi6jpd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.158.194 X-Source-L: No X-Exim-ID: 1njtcc-004JbH-Q1 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-158-194.hlrn.qwest.net (prentzel) [71.211.158.194]:34634 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2022 02:11:14 -0000 >> + PyErr_SetString (PyExc_ValueError, "Bad register"); Simon> It seems like you kept the wrong line here? If this is really an error Simon> and no test has caught this, it means we're lacking some coverage. Geez. I will look into that. I used to periodically do coverage analysis of gdb but lately lcov doesn't seem to work for me and I haven't bothered to track it down. Tom