Re: [PATCH 4/6] gdb/testsuite: add "macros" option to gdb_compile

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> From: Simon Marchi <simon.marchi@efficios.com>
Simon> Make gdb_compile handle a new "macros" option, which makes it pass the
Simon> appropriate flag to make the compiler include macro information in the
Simon> debug info.  This will help simplify tests using macros, reduce
Simon> redundant code, and make it easier to add support for a new compiler.

Simon> Right now it only handles clang specially (using -fdebug-macro) and
Simon> falls back to -g3 otherwise (which works for gcc).  Other compilers can
Simon> be added as needed.

I like this idea but I think the patch changes some tests a bit.

Simon> -set options {debug}
Simon> -
Simon> -get_compiler_info
Simon> -if { [test_compiler_info gcc*] } {
Simon> -    lappend options "additional_flags=-g3"
Simon> -} elseif { [test_compiler_info clang*] } {
Simon> -    lappend options "additional_flags=-fdebug-macro"
Simon> -} else {
Simon> -    untested "no compiler info"
Simon> -    return -1
Simon> -}
Simon> -
Simon> -if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} $options] } {
Simon> +if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {debug macros}] } {
Simon>      return -1

This one used to be untested for non-{gcc,clang} compilers, but now I
think the test will just fail.

There are some other cases like this as well.

Maybe this was intentional?  I suppose if there's a compiler that
doesn't support this, we can go back and re-added the untested / "if"s.

Tom