From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id A1DF0385DC1A for ; Mon, 14 Mar 2022 13:55:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A1DF0385DC1A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id AC5A51003EE47 for ; Mon, 14 Mar 2022 13:55:17 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id TlALnweajb2WGTlALnGDIq; Mon, 14 Mar 2022 13:55:17 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DrmTREz+ c=1 sm=1 tr=0 ts=622f4945 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=6P9GduZhxPMaVVCI:21 a=o8Y5sQTvuykA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=F4sMkR8kFuV44XxB4G8A:9 a=O2SvPiPvMCkYvN4wDMmF:22 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BBf23ygccUiQdVC4mve8zxpkxBbI4IdS8f55jrDnl8s=; b=pRZD15pVroqgybMlcchMbpsRu5 +BGUTcXMyTx4GhRw6+/D3jj/fkxOYhQEQQo+UVeogwK9phnZaHJzcdy3RFqEeiGZclj97tqlLP61Q mVPSFCWgDFMSTT1AesfakFPG9; Received: from 71-211-175-224.hlrn.qwest.net ([71.211.175.224]:37978 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nTlAK-000b6N-PG; Mon, 14 Mar 2022 07:55:16 -0600 From: Tom Tromey To: Enze Li via Gdb-patches Subject: Re: [PATCH] gdb: prevent the use of the clear command to remove the internal breakpoint (PR cli/7161) References: X-Attribution: Tom Date: Mon, 14 Mar 2022 07:55:16 -0600 In-Reply-To: (Enze Li via Gdb-patches's message of "Mon, 14 Mar 2022 20:24:06 +0800") Message-ID: <871qz4ljuj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.175.224 X-Source-L: No X-Exim-ID: 1nTlAK-000b6N-PG X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-175-224.hlrn.qwest.net (murgatroyd) [71.211.175.224]:37978 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2022 13:55:25 -0000 >>>>> Enze Li via Gdb-patches writes: > +/* See breakpoint.h. */ > +bool > +internal_breakpoint (struct breakpoint *b) > +{ > + return b->ops == &internal_breakpoint_ops; > +} I think the correct test is probably if the breakpoint number is <=0. There are, I think, "internal" breakpoints that don't use internal_breakpoint_ops. Tom