From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 0A2CA3858413 for ; Fri, 4 Mar 2022 14:53:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0A2CA3858413 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 29E8010040887 for ; Fri, 4 Mar 2022 14:53:56 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Q9JbnzTZqQs3CQ9Jbn5Utb; Fri, 04 Mar 2022 14:53:56 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=d8AwdTvE c=1 sm=1 tr=0 ts=62222804 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=o8Y5sQTvuykA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=NewijSBQlC72qKB-pCoA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Wp+f3keB3+h9rwWdBP9P7E2oXiEjv2NO1I3H7fPCBqU=; b=WCpx7/COLhb11f3N2wNgNfKBHE VhDi/PtSpyikLCqLHNiNW55WSk4ifcUaYq58vWiJy+L2HJEeNp/ZPiZQjFTNxUVVUKc0/UbeQz+Vm I4rjNYz3DiRIv0rf2O7Nlao1v; Received: from 75-166-141-253.hlrn.qwest.net ([75.166.141.253]:37894 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nQ9Jb-000l85-4h; Fri, 04 Mar 2022 07:53:55 -0700 From: Tom Tromey To: Aaron Merey via Gdb-patches Cc: Aaron Merey , tom@tromey.com, aburgess@redhat.com, lsix@lancelotsix.com Subject: Re: [PATCH 1/2] gdb: Add soname to build-id mapping for core files References: <20220303013501.265407-1-amerey@redhat.com> <20220303013501.265407-2-amerey@redhat.com> X-Attribution: Tom Date: Fri, 04 Mar 2022 07:53:54 -0700 In-Reply-To: <20220303013501.265407-2-amerey@redhat.com> (Aaron Merey via Gdb-patches's message of "Wed, 2 Mar 2022 20:35:00 -0500") Message-ID: <871qzhvke5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.141.253 X-Source-L: No X-Exim-ID: 1nQ9Jb-000l85-4h X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-141-253.hlrn.qwest.net (murgatroyd) [75.166.141.253]:37894 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 14:54:00 -0000 >>>>> "Aaron" == Aaron Merey via Gdb-patches writes: Aaron> Since commit aa2d5a422 gdb has been able to read executable and shared Aaron> library build-ids within core files. Aaron> Expand this functionality so that each core file bfd maintains a map of Aaron> soname to build-id for each shared library referenced in the core file. Aaron> This feature may be used to verify that gdb has found the correct shared Aaron> libraries for core files and to facilitate downloading shared libaries via Aaron> debuginfod. Thanks for working on this. Aaron> + gdb::unique_xmalloc_ptr soname = Aaron> + gdb_bfd_read_elf_soname (bfd->filename); The '=' should go after the line break. Aaron> +/* Mapping of a core file's shared library sonames to their respective Aaron> + build-ids. Added to the registries of core file bfds. */ Aaron> + Aaron> +typedef std::unordered_map soname_build_id_map; Aaron> + Aaron> +/* Key used to associate a soname_build_id_map to a core file bfd. */ Aaron> + Aaron> +static const struct bfd_data *cbfd_soname_build_id_data_key; I think it's better to use the template form, like static const struct bfd_key cbfd_soname_build_id_data_key; More comments on this below. Aaron> + soname_build_id_map *mapptr = (soname_build_id_map *) Aaron> + bfd_data (abfd.get (), cbfd_soname_build_id_data_key); ... this cast won't be needed: soname_build_id_map *mapptr = cbfd_soname_build_id_data_key.get (abfd.get ()); Aaron> + if (mapptr == nullptr) Aaron> + { Aaron> + mapptr = new soname_build_id_map (); Aaron> + set_bfd_data (abfd.get (), cbfd_soname_build_id_data_key, mapptr); mapptr = cbfd_soname_build_id_data_key.emplace (abfd.get ()); Aaron> +/* See solib.h. */ Aaron> + Aaron> +gdb::unique_xmalloc_ptr Aaron> +get_cbfd_soname_build_id (gdb_bfd_ref_ptr abfd, const char *soname) Aaron> +{ Why does this return a unique_xmalloc_ptr? Aaron> +/* Free memory allocated for a soname_build_id_map. */ Aaron> + Aaron> +static void Aaron> +delete_soname_build_id_map (struct bfd *abfd, void *mapptr) Aaron> +{ Aaron> + if (mapptr != nullptr) Aaron> + delete (soname_build_id_map *) mapptr; Aaron> +} With the template form, this can go away entirely. Aaron> _initialize_solib () Aaron> { Aaron> solib_data = gdbarch_data_register_pre_init (solib_init); Aaron> + cbfd_soname_build_id_data_key = (const struct bfd_data *) Aaron> + register_bfd_data_with_cleanup (nullptr, delete_soname_build_id_map); This won't be needed with the template form. Tom