From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B32E43858D37 for ; Wed, 2 Mar 2022 16:39:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B32E43858D37 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-447-R3IdeunVNUeetA6tmjiEDA-1; Wed, 02 Mar 2022 11:39:26 -0500 X-MC-Unique: R3IdeunVNUeetA6tmjiEDA-1 Received: by mail-wm1-f72.google.com with SMTP id az36-20020a05600c602400b003811b328ed5so710066wmb.4 for ; Wed, 02 Mar 2022 08:39:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=sGEr6HlgkrvYo2niIpv6txz/QZDdIWdwZcNhk8vJjYg=; b=2dS5W9wsmpZeJLm86e47MUR5gx3OV6ClUmmiWrrYlme9GsKRuWLmGX1C99x7juNfi1 iqivtpnKjgJ8kPedR4I8dZHIln3mgKdJJ8edhscp21PhoVq8LMxVdYHAOVHMa3Dovf8s w9wM0Vr0+ceI3fKdXUTjCinQHvQmujsDctxXV0tbrgdemxn+j9wNYuTBRPxp5pNwycN1 rlj92ggLucNdvRuOGmnmiqfeoIrdKoleqWfdF1Ts6TQokagpzMaxnepfpn/A9vOhWO4+ KwjA19GJ/FZWOQTjxCH9op/8ZvLa+2LH4VjOiqPz7nfyfHljSgPMZuGaShxaPll4iCtM 0YZg== X-Gm-Message-State: AOAM531LwJgEah/mk/JYPRt72lR5ABfE1jSnKstFt67h/5hscpJgcq9A oeP8CFmMa2T24pIp6H7Xl4I24Ex9iDN1vDNu9Yr82eVGocXLdViBkZ1J4oCSL1Hgoc1zm89ib5I kGJ2WDR3DSGky2VJWD6HpFA== X-Received: by 2002:adf:a35e:0:b0:1f0:9f2:a65e with SMTP id d30-20020adfa35e000000b001f009f2a65emr6891384wrb.535.1646239164778; Wed, 02 Mar 2022 08:39:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJz1wzirBnsTEPtfBVscKuNWfjgwHhryxMoBU7yWAEH27gMqqFQGjXRatFzHQ7TkmPbQNznBRg== X-Received: by 2002:adf:a35e:0:b0:1f0:9f2:a65e with SMTP id d30-20020adfa35e000000b001f009f2a65emr6891365wrb.535.1646239164532; Wed, 02 Mar 2022 08:39:24 -0800 (PST) Received: from localhost (host86-169-131-29.range86-169.btcentralplus.com. [86.169.131.29]) by smtp.gmail.com with ESMTPSA id d25-20020adfa419000000b001f04b3a4b46sm26274wra.94.2022.03.02.08.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 08:39:24 -0800 (PST) From: Andrew Burgess To: Pedro Alves , Bruno Larsen , gdb-patches@sourceware.org Subject: Re: [PATCH 01/11] change gdb.base/skip.exp to use finish instead of step In-Reply-To: <50f75fc6-df4b-8408-4843-7d3363ed6f1a@palves.net> References: <20220126195053.69559-1-blarsen@redhat.com> <20220126195053.69559-2-blarsen@redhat.com> <50f75fc6-df4b-8408-4843-7d3363ed6f1a@palves.net> Date: Wed, 02 Mar 2022 16:39:23 +0000 Message-ID: <871qzkz4uc.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2022 16:39:28 -0000 Pedro Alves writes: > On 2022-01-26 19:50, Bruno Larsen via Gdb-patches wrote: >> skip.exp was making use of a fixed amount of step commands to exit >> some functions. This caused some problems when testing GDB with clang, >> as it doesn't add epilogue information for functions. Since the step >> commands weren't testing important features, they were changed to finish >> commands. > > I'm not a fan of _completely_ avoiding stepping out of functions, due to some > compilers misbehaving. I mean, if we're going to do this throughout > the testsuite, then we should at least have one testcase that is explicitly > about stepping out of a function with step, one that exhibits the problem, > and we can concentrate the xfails there (and we should press the compiler > folks to fix it). I'm not sure we have one. If we do, you should mention it > explicitly in the commit log. Afterall, users will be doing this too. Agreed, and there's probably scope for a proc in lib/gdb.exp that does something like "step until we reach a source line matching REGEXP", which could be used instead of finish in some cases. Thanks, Andrew