From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.144.219]) by sourceware.org (Postfix) with ESMTPS id A5C88386EC43 for ; Wed, 21 Apr 2021 19:30:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A5C88386EC43 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 1774F6074C6 for ; Wed, 21 Apr 2021 14:29:35 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ZIXWl0m6k1cHeZIXXl7s6T; Wed, 21 Apr 2021 14:29:35 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JrZy7xxsuOiRBE/WqCVwaX2YAzx3tFnPcvdZVKrOpPs=; b=jDtnKTnj43Mcc2bk28CE7YYlF9 UfmmIxNyDjRmI30VMafBiW/v/XuclUx60k4ocwUP3MaMuqvJI4EPcVLOkLsc8zUz+06AcJG05fUPl XzgGxHm6Tg0svg1r21hJBuCat; Received: from 71-211-182-15.hlrn.qwest.net ([71.211.182.15]:54362 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lZIXW-003GE0-8a; Wed, 21 Apr 2021 13:29:34 -0600 From: Tom Tromey To: Tankut Baris Aktemur via Gdb-patches Subject: Re: [PATCH 3/6] gdb/continuations: remove the 'err' from 'do_all_inferior_continuations' References: <6152bd70e6450247a4d2bcc516e6be590dce7e0d.1619009681.git.tankut.baris.aktemur@intel.com> X-Attribution: Tom Date: Wed, 21 Apr 2021 13:29:33 -0600 In-Reply-To: <6152bd70e6450247a4d2bcc516e6be590dce7e0d.1619009681.git.tankut.baris.aktemur@intel.com> (Tankut Baris Aktemur via Gdb-patches's message of "Wed, 21 Apr 2021 14:57:28 +0200") Message-ID: <871rb3bfmq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.182.15 X-Source-L: No X-Exim-ID: 1lZIXW-003GE0-8a X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-182-15.hlrn.qwest.net (murgatroyd) [71.211.182.15]:54362 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2021 19:30:18 -0000 >>>>> ">" == Tankut Baris Aktemur via Gdb-patches writes: >> The 'err' parameter of 'do_all_inferior_continuations' is effectively >> unused. There is only one place where the function is called, and >> there the argument is a literal 0. So, remove the parameter. >> gdb/ChangeLog: >> 2021-04-21 Tankut Baris Aktemur >> * continuations.h (do_all_inferior_continuations): Remove the 'err' >> parameter. Update the references below. >> * continuations.c (do_my_continuations_1) >> (do_my_continuations) >> (do_all_inferior_continuations): Update. >> * inf-loop.c (inferior_event_handler): Update. >> * infcmd.c (attach_command_continuation): Update. Looks good. Thank you. Tom