From: Tom Tromey <tom@tromey.com>
To: Christian Biesinger via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] Use RAII to set the per-thread SIGSEGV handler
Date: Fri, 12 Mar 2021 07:27:23 -0700 [thread overview]
Message-ID: <871rck4fck.fsf@tromey.com> (raw)
In-Reply-To: <20210309170013.2948735-1-cbiesinger@google.com> (Christian Biesinger via Gdb-patches's message of "Tue, 9 Mar 2021 11:00:13 -0600")
>>>>> "Christian" == Christian Biesinger via Gdb-patches <gdb-patches@sourceware.org> writes:
Christian> PR threads/27239
This should be in the ChangeLog entry.
Christian> +/* The SIGSEGV handler for this thread, or NULL if there is none. GDB
Christian> + always installs a global SIGSEGV handler, and then lets threads
Christian> + indicate their interest in handling the signal by setting this
Christian> + thread-local variable. */
Christian> -thread_local void (*thread_local_segv_handler) (int);
Christian> +static thread_local void (*thread_local_segv_handler) (int);
I think it would be good for the comment to say something about why this
is static, and why scoped_segv_handler_restore is needed.
Otherwise this looks good to me. It's ok with those two changes.
It's fine for the 10.x branch as well.
thank you,
Tom
next prev parent reply other threads:[~2021-03-12 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 14:23 [PATCH] " Christian Biesinger
2021-03-09 17:00 ` [PATCH v2] " Christian Biesinger
2021-03-12 14:27 ` Tom Tromey [this message]
2021-03-12 17:30 ` Christian Biesinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rck4fck.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).