From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.149.13]) by sourceware.org (Postfix) with ESMTPS id BAD9A3846020 for ; Fri, 12 Mar 2021 14:27:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BAD9A3846020 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 57B615186D for ; Fri, 12 Mar 2021 08:27:24 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id KilAl469UiQiZKilAl6W6N; Fri, 12 Mar 2021 08:27:24 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BAvyQxyy2jtJ7x7Qk63yMlwXyiSUsEV0isyaUvMc7V8=; b=fOdFt2SYbtp5vmq4iNVWGx0cqe 3hIz+c8GqGYeGJ65JlWDIMB1AONGW4lIot9PHOlB5SEjz8ZSXezdNCekyRv+yA4Kx/s9icNF3ld6m SJ4c0cFzA+bxLmGAsIA/35nSv; Received: from 71-211-137-228.hlrn.qwest.net ([71.211.137.228]:36418 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lKilA-004FAS-2n; Fri, 12 Mar 2021 07:27:24 -0700 From: Tom Tromey To: Christian Biesinger via Gdb-patches Subject: Re: [PATCH v2] Use RAII to set the per-thread SIGSEGV handler References: <20210309142347.2927653-1-cbiesinger@google.com> <20210309170013.2948735-1-cbiesinger@google.com> X-Attribution: Tom Date: Fri, 12 Mar 2021 07:27:23 -0700 In-Reply-To: <20210309170013.2948735-1-cbiesinger@google.com> (Christian Biesinger via Gdb-patches's message of "Tue, 9 Mar 2021 11:00:13 -0600") Message-ID: <871rck4fck.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.137.228 X-Source-L: No X-Exim-ID: 1lKilA-004FAS-2n X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-137-228.hlrn.qwest.net (murgatroyd) [71.211.137.228]:36418 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Mar 2021 14:27:26 -0000 >>>>> "Christian" == Christian Biesinger via Gdb-patches writes: Christian> PR threads/27239 This should be in the ChangeLog entry. Christian> +/* The SIGSEGV handler for this thread, or NULL if there is none. GDB Christian> + always installs a global SIGSEGV handler, and then lets threads Christian> + indicate their interest in handling the signal by setting this Christian> + thread-local variable. */ Christian> -thread_local void (*thread_local_segv_handler) (int); Christian> +static thread_local void (*thread_local_segv_handler) (int); I think it would be good for the comment to say something about why this is static, and why scoped_segv_handler_restore is needed. Otherwise this looks good to me. It's ok with those two changes. It's fine for the 10.x branch as well. thank you, Tom