From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Hannes Domani <ssbssa@yahoo.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH 03/22] Forward mouse click to python TUI window
Date: Thu, 11 Mar 2021 14:19:06 -0700 [thread overview]
Message-ID: <871rcl75it.fsf@tromey.com> (raw)
In-Reply-To: <20210308093619.GJ1720904@embecosm.com> (Andrew Burgess's message of "Mon, 8 Mar 2021 09:36:19 +0000")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
>> + void click (int mouse_x, int mouse_y, int mouse_button) override;
Andrew> Unfortunately py-tui.c is pretty hit & miss w.r.t. comments, but this
Andrew> function really should be commented.
FWIW I've normally considered "override" as sufficient to mean "see the
comment in the superclass"; though I am not very adamant about this.
Tom
next prev parent reply other threads:[~2021-03-11 21:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210306173417.21528-1-ssbssa.ref@yahoo.de>
2021-03-06 17:33 ` [RFC] TUI windows for locals/display/threads/frames/memory Hannes Domani
2021-03-06 17:33 ` [PATCH 01/22] Initial TUI mouse support Hannes Domani
2021-03-11 17:32 ` Tom Tromey
2021-03-11 17:48 ` Hannes Domani
2021-03-12 16:35 ` Tom Tromey
2021-03-12 16:43 ` Hannes Domani
2021-03-12 17:02 ` Tom Tromey
2021-03-06 17:33 ` [PATCH 02/22] Create/disable/enable/delete breakpoints in TUI with mouse Hannes Domani
2021-03-08 9:32 ` Andrew Burgess
2021-03-08 12:00 ` Hannes Domani
2021-03-11 21:17 ` Tom Tromey
2021-03-11 21:16 ` Tom Tromey
2021-03-06 17:33 ` [PATCH 03/22] Forward mouse click to python TUI window Hannes Domani
2021-03-06 18:09 ` Eli Zaretskii
2021-03-08 9:36 ` Andrew Burgess
2021-03-11 21:19 ` Tom Tromey [this message]
2021-03-11 21:20 ` Tom Tromey
2021-03-06 17:33 ` [PATCH 04/22] Prevent flickering when redrawing the TUI python window Hannes Domani
2021-03-11 21:21 ` Tom Tromey
2021-03-06 17:34 ` [PATCH 05/22] Implement locals TUI window Hannes Domani
2021-03-08 9:51 ` Andrew Burgess
2021-03-11 21:26 ` Tom Tromey
2021-03-11 21:33 ` Tom Tromey
2021-03-11 22:00 ` Tom Tromey
2021-03-06 17:34 ` [PATCH 06/22] Implement display " Hannes Domani
2021-03-11 21:37 ` Tom Tromey
2021-03-06 17:34 ` [PATCH 07/22] Implement threads " Hannes Domani
2021-03-06 17:34 ` [PATCH 08/22] Implement frames " Hannes Domani
2021-03-11 21:40 ` Tom Tromey
2021-03-11 21:50 ` Hannes Domani
2021-03-06 17:34 ` [PATCH 09/22] Implement cccw TUI command Hannes Domani
2021-03-08 10:24 ` Christian Biesinger
2021-03-11 21:42 ` Tom Tromey
2021-03-11 21:57 ` [RFC] TUI windows for locals/display/threads/frames/memory Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rcl75it.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=ssbssa@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).