From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.51.253]) by sourceware.org (Postfix) with ESMTPS id BA0A6389441A for ; Thu, 11 Mar 2021 21:19:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BA0A6389441A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 35AC64606 for ; Thu, 11 Mar 2021 15:19:08 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id KSi4lcDwlkscSKSi4lYQq6; Thu, 11 Mar 2021 15:19:08 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cymBODtwOpuiODUByDPKCwpzwy1SCWsrN4QYBACOV+4=; b=MjS/cnkP8vM6cByxKcpQlMwR2r k51I1fUuoXtBOmgWM55ZgoNiyq3hPn4r/1MFCFfEFL6ottI2qAzTilARoGiy963+8tHtn29dC8NUx u6+hMylYa8gOPbAFCYwZPvdxe; Received: from 71-211-137-228.hlrn.qwest.net ([71.211.137.228]:35512 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lKSi3-000Kni-Le; Thu, 11 Mar 2021 14:19:07 -0700 From: Tom Tromey To: Andrew Burgess Cc: Hannes Domani , gdb-patches@sourceware.org Subject: Re: [PATCH 03/22] Forward mouse click to python TUI window References: <20210306173417.21528-1-ssbssa@yahoo.de> <20210306173417.21528-4-ssbssa@yahoo.de> <20210308093619.GJ1720904@embecosm.com> X-Attribution: Tom Date: Thu, 11 Mar 2021 14:19:06 -0700 In-Reply-To: <20210308093619.GJ1720904@embecosm.com> (Andrew Burgess's message of "Mon, 8 Mar 2021 09:36:19 +0000") Message-ID: <871rcl75it.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.137.228 X-Source-L: No X-Exim-ID: 1lKSi3-000Kni-Le X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-137-228.hlrn.qwest.net (murgatroyd) [71.211.137.228]:35512 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 21:19:09 -0000 >>>>> "Andrew" == Andrew Burgess writes: >> + void click (int mouse_x, int mouse_y, int mouse_button) override; Andrew> Unfortunately py-tui.c is pretty hit & miss w.r.t. comments, but this Andrew> function really should be commented. FWIW I've normally considered "override" as sufficient to mean "see the comment in the superclass"; though I am not very adamant about this. Tom