From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.212]) by sourceware.org (Postfix) with ESMTPS id 5E46D3851C35 for ; Mon, 13 Jul 2020 18:21:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5E46D3851C35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id DC65DEC12 for ; Mon, 13 Jul 2020 13:21:42 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id v35CjKDSSXGIkv35CjSfvD; Mon, 13 Jul 2020 13:21:42 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cqxx3/I4FeO+nHTvi2CO6LnhTGgj8qwIyrOp5j+/orI=; b=fwyhrYHpwBSD/RE46ajohqazZn 4nI0K1AA2k2MdWLwgn5Ezkoh0w6vLrsYiZA2B0IQfX1wUQJAOnzX56BXpLNXdnA45BMSZe0jOvblE M6gFtk8sBsLNUg+BRG6hmgTEy; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:53818 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jv35C-003jUU-HR; Mon, 13 Jul 2020 12:21:42 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb/python: Reuse gdb.RegisterDescriptor objects where possible References: <325856d3d21fd0f417d4ec0bfd9b233c0190c780.1594197735.git.andrew.burgess@embecosm.com> X-Attribution: Tom Date: Mon, 13 Jul 2020 12:21:41 -0600 In-Reply-To: <325856d3d21fd0f417d4ec0bfd9b233c0190c780.1594197735.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Wed, 8 Jul 2020 09:48:11 +0100") Message-ID: <871rlf8edm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jv35C-003jUU-HR X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:53818 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2020 18:21:52 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> * python/py-registers.c (gdbpy_register_object_data): New static Andrew> global. Andrew> (gdbpy_register_object_data_init): New function. Andrew> (gdbpy_new_register_descriptor): Renamed to... Andrew> (gdbpy_get_register_descriptor): ...this, and update to reuse Andrew> existing register descriptors where possible. Andrew> (gdbpy_register_descriptor_iter_next): Update. Andrew> (gdbpy_initialize_registers): Register new gdbarch data. This looks reasonable to me. Andrew> +static void * Andrew> +gdbpy_register_object_data_init (struct gdbarch *gdbarch) Andrew> +{ Andrew> + std::vector *vec Andrew> + = new (std::vector); Andrew> + return (void *) vec; It seems a bit strange to use "const" here, since the refcounts do change, and the code has to cast away const elsewhere. Also I wonder if a vector of PyObject* or even gdb_pyref<> would be better. Tom