From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.69.18]) by sourceware.org (Postfix) with ESMTPS id 0D2FC38708D0 for ; Mon, 15 Jun 2020 14:06:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0D2FC38708D0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 3A791400D8592 for ; Mon, 15 Jun 2020 07:46:34 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id kpkvjXCurwgQAkpkvj5Jkq; Mon, 15 Jun 2020 09:06:33 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CINMsl1tV1Uj5Dut0QvvFzsd1ygINP5zVgDgKmDn7uk=; b=AIaSzY7H5Dwk5Mg6C5HGKDRUGN UJEN+JtRtTEBQQGs0j614Fn2Y5u1NzkKo4flYiJF23jpTVXF+jU53F8+3u019w7ehFLLEaMQDxxUb Nu/ewZRneoZikaOo53vnlEkk+; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:57862 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jkpkv-004GR9-7m; Mon, 15 Jun 2020 08:06:33 -0600 From: Tom Tromey To: Stephanos Ioannidis Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: Disable source-highlight static libstdc++ check References: <20200602035206.132185-1-root@stephanos.io> X-Attribution: Tom Date: Mon, 15 Jun 2020 08:06:32 -0600 In-Reply-To: <20200602035206.132185-1-root@stephanos.io> (Stephanos Ioannidis's message of "Tue, 2 Jun 2020 12:52:06 +0900") Message-ID: <871rmgmniv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jkpkv-004GR9-7m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:57862 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2020 14:06:35 -0000 >>>>> "Stephanos" == Stephanos Ioannidis writes: Hi. Thanks for the patch. Stephanos> This patch removes the libstdc++ static linking prevention check when Stephanos> the libsource-highlight (aka. GNU Source Highlight) library is used. Patches have to come with a ChangeLog entry. See the contribution checklist: https://sourceware.org/gdb/wiki/ContributionChecklist Stephanos> The commit d806ea2d0ef362fcddd2c1659f537b68aa114203 introduced this Stephanos> requirement in order to prevent exception handling issues when mixing Stephanos> dynamic C++ libraries and static libstdc++; however, this restriction Stephanos> does not apply when all linked C++ libraries are in the static form. It seems like this would just reintroduce the build problem that this addition was intended to fix. Maybe some option to circumvent this check would be better. Tom