From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 53BF63858D34 for ; Sat, 16 May 2020 06:42:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 53BF63858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=whitebox@nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 49PG1W0nVBz1qs0h; Sat, 16 May 2020 08:42:54 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 49PG1V6CPQz1shdw; Sat, 16 May 2020 08:42:54 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id YLmuIusvCnmB; Sat, 16 May 2020 08:42:54 +0200 (CEST) X-Auth-Info: WMcywXZ5tRartqwqP3rst7gXWoX8cK4a1Zn6piwcKMyUAA+KQEMxiHjUMOPLjOIx Received: from hase.home (ppp-46-244-164-135.dynamic.mnet-online.de [46.244.164.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sat, 16 May 2020 08:42:54 +0200 (CEST) Received: by hase.home (Postfix, from userid 1000) id 1886310130D; Sat, 16 May 2020 08:42:52 +0200 (CEST) From: Andreas Schwab To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH] gdb: fix -Wtautological-overlap-compare warning in mips-linux-tdep.c References: <20200516020151.34919-1-simon.marchi@efficios.com> X-Yow: "THE LITTLE PINK FLESH SISTERS," I saw them at th' FLUORESCENT BULB MAKERS CONVENTION... Date: Sat, 16 May 2020 08:42:52 +0200 In-Reply-To: <20200516020151.34919-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Fri, 15 May 2020 22:01:51 -0400") Message-ID: <871rnkwfbn.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 May 2020 06:42:57 -0000 On Mai 15 2020, Simon Marchi via Gdb-patches wrote: > Indeed, given two different values, `insn` will always be different to > one of them, and these conditions always be true. I suppose that the > original intent was "if insn is equal to this instruction or equal to > that instruction". Therefore the `!=` should be changed to `==`. I don't think that makes sense. Rather || should be fixed to &&. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."