From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway30.websitewelcome.com (gateway30.websitewelcome.com [192.185.197.25]) by sourceware.org (Postfix) with ESMTPS id 0CE11383E831 for ; Mon, 11 May 2020 16:55:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0CE11383E831 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 65B0CB6BB for ; Mon, 11 May 2020 11:55:36 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id YBiKjMDAT1s2xYBiKjujp5; Mon, 11 May 2020 11:55:36 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CTEoH9gjgexWl5GgUMTPJgmt0wCdnD1edwG1tV9FIEw=; b=noMnZLvG+sb7aAR8iNbi5zF9b/ U0SNpsfj3xgMZEJFWioIXzZcWyh4z3ZgFruEtVPit7VIuX9V1lug0ESXyA6dzZwOu/VYMZgEDDZM6 +BZ9qnHQqJI6KtGMSfJLwccHx; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:50044 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jYBiK-004F95-0C; Mon, 11 May 2020 10:55:36 -0600 From: Tom Tromey To: Pedro Alves via Gdb-patches Cc: Tom Tromey , Pedro Alves , Simon Marchi Subject: Re: [PATCH 0/7] Make gdbarch.sh shellcheck-clean References: <20200428214655.3255454-1-simon.marchi@efficios.com> <878sie57an.fsf@tromey.com> <94e06111-2801-644f-3906-7c622d1ec611@redhat.com> X-Attribution: Tom Date: Mon, 11 May 2020 10:55:35 -0600 In-Reply-To: <94e06111-2801-644f-3906-7c622d1ec611@redhat.com> (Pedro Alves via Gdb-patches's message of "Sun, 10 May 2020 19:57:09 +0100") Message-ID: <871rnqmmwo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jYBiK-004F95-0C X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:50044 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2020 16:55:38 -0000 >>>>> "Pedro" == Pedro Alves via Gdb-patches writes: Pedro> My main gripe with gdbarch.sh is that the function/variable/method definitions Pedro> and the generator code is all in the same file. Pedro> If those were split to separate files, like, the definitions inside function_list() Pedro> were moved to a separate gdbarch.def file, which would be read by gdbarch.sh, Pedro> that'd already be a large win, IMHO. Pedro> Also, I would like it to be able to generate the gdbarch.h/c files in place, Pedro> instead of generating new "new-gdbarch.h/c" files. Another option would be to go with a .def-style file, but using #include and #define to turn it into C++ code, like we do with other files. There's basically two things I don't like about the current setup. One problem is that the current code is hard to read. Any of the ideas we've discussed would fix this. The other problem is not just that the output files are new-gdbarch.[ch] -- that can be fixed with a simple script tweak -- but that the script has to be run manually to update & commit the output. This bites me occasionally; it would be preferable by far if it were simply integrated into the build in a normal way. This latter thing is a problem with make-target-delegates as well, though I touch that one a lot less often, so it doesn't irritate as much. Tom