From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43904 invoked by alias); 28 Feb 2020 15:23:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43859 invoked by uid 89); 28 Feb 2020 15:23:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=general-purpose, generalpurpose X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.149.77) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Feb 2020 15:23:29 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 4F6FC131F02A for ; Fri, 28 Feb 2020 09:23:28 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 7hU7jQrJWAGTX7hU7jZmv8; Fri, 28 Feb 2020 09:23:28 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ir+XnhBY7hIGUKPGEs1OyN6DS/Dyl5iIfIuMs6dNDKI=; b=NDF+P5eDmHFSO9xvB2v3OvdwON DXgx28NpaPhQAM6ijRrm0oN68wBLxVCTMZXoR0RWaafbzbfrrXGpL3Y+vNhNau76RoYKKBYBUK4O7 0Iz+kKEOngbv5JAGfqFjvaotb; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:38654 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j7hU7-003nKm-I9; Fri, 28 Feb 2020 08:23:27 -0700 From: Tom Tromey To: Sergio Durigan Junior Cc: GDB Patches , Pedro Alves , Tom Tromey , Eli Zaretskii , Ruslan Kabatsayev Subject: Re: [PATCH 1/6] Introduce scoped_pipe.h References: <20190926042155.31481-1-sergiodj@redhat.com> <20200226200542.746617-1-sergiodj@redhat.com> <20200226200542.746617-2-sergiodj@redhat.com> Date: Fri, 28 Feb 2020 15:23:00 -0000 In-Reply-To: <20200226200542.746617-2-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Wed, 26 Feb 2020 15:05:37 -0500") Message-ID: <871rqeka6p.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg01056.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> gdb/ChangeLog: Sergio> yyyy-mm-dd Sergio Durigan Junior Sergio> * unittests/scoped_pipe-selftests.c: New file. Sergio> gdbsupport/ChangeLog: Sergio> yyyy-mm-dd Sergio Durigan Junior Sergio> * scoped_pipe.h: New file. I think new general-purpose code should go in gdbsupport. Unfortunately right now we don't have a good way to put the unit tests there. This is something we ought to do eventually though. Sergio> +#ifndef COMMON_SCOPED_PIPE_H I think we've been using GDBSUPPORT rather than COMMON now. Sergio> + explicit scoped_pipe () I think explicit is only needed for 1-arg constructors. Tom