From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33671 invoked by alias); 17 Jan 2020 18:11:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33663 invoked by uid 89); 17 Jan 2020 18:11:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=commission, apologies X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jan 2020 18:11:45 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id C45DB2DAEB7 for ; Fri, 17 Jan 2020 12:11:43 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id sW5viJVfbqNtvsW5viv1qR; Fri, 17 Jan 2020 12:11:43 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=R5Cg4j+t1aQQoKo9Ro45JKtmScdJvVFVhE2LQirpxrk=; b=LRqov3Cq2CfQfhnWsLS1bKt9a+ p8otPk7c5HuLveKx25QmT9PghfUezOTxEJRv0kjnB+sMzRgtHnHocsyQ9d4M63sGol8UZsFhCiXt/ Eqelpxh3F8CmDWfwJMVrGju6+; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:56466 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1isW5v-000DMh-HG; Fri, 17 Jan 2020 11:11:43 -0700 From: Tom Tromey To: Pedro Alves Cc: Simon Marchi , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 0/6] Move gdbsupport to top level References: <20200109005807.7314-1-tom@tromey.com> <8a8de6a9-37b8-cad3-c818-be903037fe48@redhat.com> <437c1b86-0aa8-57b9-53e2-f21567e2bb14@redhat.com> <87c733a2-2b25-a954-88a1-9bfb1a7eca12@redhat.com> <4fed38dc-aaa7-b76b-880f-bab0b1b5add2@redhat.com> <053b43db-381c-a72d-ea5d-9bcb74a8440c@simark.ca> <78d5599b-9773-954f-ea06-86f65a1c6842@redhat.com> <2cb89dd1-f029-d495-4823-72ae2d5253d2@simark.ca> <6b0b7f90-f526-73a9-3de8-aea958688d15@redhat.com> Date: Fri, 17 Jan 2020 18:13:00 -0000 In-Reply-To: <6b0b7f90-f526-73a9-3de8-aea958688d15@redhat.com> (Pedro Alves's message of "Fri, 17 Jan 2020 15:17:52 +0000") Message-ID: <871rryhs0x.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00553.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >>> Approach #3 - rename support-config.h -> config.h >> >> I'd say let's go for #3, since that's how gdb and gdbserver already work, >> it's been working well for years, so it's proven already. Pedro> I've merged #3 now. We discussed adding a comment to Pedro> gdbsupport/Makefile.am about the order of include paths, but it Pedro> turns out that the -I. is added by automake by default Pedro> (DEFAULT_INCLUDES), not explicitly set. gdb and gdbserver's Pedro> Makefile.in have comments about it already. So I applied the Pedro> patch as it was. Thank you for doing this, and please accept my apologies for landing that patch and then being out of commission for the following days. Tom