public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH 3/3] Load system gdbinit files from a directory
Date: Wed, 21 Aug 2019 18:15:00 -0000	[thread overview]
Message-ID: <871rxegzb4.fsf@redhat.com> (raw)
In-Reply-To: <20190820221745.147370-4-cbiesinger@google.com> (Christian	Biesinger via gdb-patches's message of "Tue, 20 Aug 2019 17:17:45	-0500")

On Tuesday, August 20 2019, Christian Biesinger via gdb-patches wrote:

> diff --git a/gdb/configure b/gdb/configure
> index cb71bbf057..e5aa2e6b3b 100755
> --- a/gdb/configure
> +++ b/gdb/configure
> @@ -693,6 +693,7 @@ WIN32LIBS
>  SER_HARDWIRE
>  WERROR_CFLAGS
>  WARN_CFLAGS
> +SYSTEM_GDBINIT_DIR
>  SYSTEM_GDBINIT
>  TARGET_SYSTEM_ROOT
>  CONFIG_LDFLAGS
> @@ -824,6 +825,7 @@ infodir
>  docdir
>  oldincludedir
>  includedir
> +runstatedir
>  localstatedir
>  sharedstatedir
>  sysconfdir
> @@ -884,6 +886,7 @@ with_libipt_prefix
>  with_included_regex
>  with_sysroot
>  with_system_gdbinit
> +with_system_gdbinit_dir
>  enable_werror
>  enable_build_warnings
>  enable_gdb_build_warnings
> @@ -956,6 +959,7 @@ datadir='${datarootdir}'
>  sysconfdir='${prefix}/etc'
>  sharedstatedir='${prefix}/com'
>  localstatedir='${prefix}/var'
> +runstatedir='${localstatedir}/run'
>  includedir='${prefix}/include'
>  oldincludedir='/usr/include'
>  docdir='${datarootdir}/doc/${PACKAGE}'
> @@ -1208,6 +1212,15 @@ do
>    | -silent | --silent | --silen | --sile | --sil)
>      silent=yes ;;
>  
> +  -runstatedir | --runstatedir | --runstatedi | --runstated \
> +  | --runstate | --runstat | --runsta | --runst | --runs \
> +  | --run | --ru | --r)
> +    ac_prev=runstatedir ;;
> +  -runstatedir=* | --runstatedir=* | --runstatedi=* | --runstated=* \
> +  | --runstate=* | --runstat=* | --runsta=* | --runst=* | --runs=* \
> +  | --run=* | --ru=* | --r=*)
> +    runstatedir=$ac_optarg ;;
> +

Something else I forgot to comment: this 'runstatedir' addition seems
unrelated to the patch; it's probably due to the autoconf version you're
using to regenerate these files.

Make sure you have the correct versions installed:

  https://sourceware.org/gdb/wiki/DeveloperTips#Editing_configure.ac

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

  parent reply	other threads:[~2019-08-21 18:15 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20 22:17 [PATCH 0/3] [RFC] Load " Christian Biesinger via gdb-patches
2019-08-20 22:18 ` [PATCH 2/3] Factor out the code to do the datadir-relocation for gdbinit Christian Biesinger via gdb-patches
2019-08-21 17:19   ` Sergio Durigan Junior
2019-08-21 17:44     ` Christian Biesinger via gdb-patches
2019-08-21 17:44       ` [PATCH 2/3 v2] " Christian Biesinger via gdb-patches
2019-08-21 17:47       ` [PATCH 2/3] " Sergio Durigan Junior
2019-08-21 18:08         ` Christian Biesinger via gdb-patches
2019-08-21 18:10           ` Sergio Durigan Junior
2019-08-20 22:18 ` [PATCH 1/3] Refactor get_init_files to use std::string Christian Biesinger via gdb-patches
2019-08-21 17:13   ` Sergio Durigan Junior
2019-08-21 17:29     ` Christian Biesinger via gdb-patches
2019-08-21 17:31       ` [PATCH 1/3 v2] " Christian Biesinger via gdb-patches
2019-08-21 17:34       ` [PATCH 1/3] " Sergio Durigan Junior
2019-08-20 22:18 ` [PATCH 3/3] Load system gdbinit files from a directory Christian Biesinger via gdb-patches
2019-08-21 17:32   ` Sergio Durigan Junior
2019-08-26  0:25     ` Christian Biesinger via gdb-patches
2019-08-26  0:33       ` [PATCH 3/3 v2] " Christian Biesinger via gdb-patches
2019-08-26  7:22         ` Eli Zaretskii
2019-09-12 22:12           ` Christian Biesinger via gdb-patches
2019-09-24 16:30             ` [PATCH 3/3 v3] " Christian Biesinger via gdb-patches
2019-10-03 18:42               ` Christian Biesinger via gdb-patches
2019-10-13  1:19                 ` Christian Biesinger via gdb-patches
2019-08-21 18:15   ` Sergio Durigan Junior [this message]
2019-08-21 18:46     ` [PATCH 3/3] " Christian Biesinger via gdb-patches
2019-08-21 18:13 ` [PATCH 0/3] [RFC] Load " Pedro Alves
2019-08-21 18:33   ` Christian Biesinger via gdb-patches
2019-08-21 18:54     ` Sergio Durigan Junior
2019-08-25 22:24   ` Christian Biesinger via gdb-patches
2019-08-26 13:31     ` Pedro Alves
2019-09-12 22:14       ` Christian Biesinger via gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rxegzb4.fsf@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).