From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107119 invoked by alias); 26 Jul 2019 18:50:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107008 invoked by uid 89); 26 Jul 2019 18:50:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.180.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Jul 2019 18:50:09 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id A2D5E5627 for ; Fri, 26 Jul 2019 13:50:08 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id r5I8hcxyodnCer5I8h6s0p; Fri, 26 Jul 2019 13:50:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QOjk3g/sD4lqUq18v7xCXVkyvWinSg0p3nT5zrgeboE=; b=PzAAN5+20Dnra3732lotjqBErT KkgEV6NTkiylftIqCQYNpCTglirPChXL6NbKuYQ3QWi+rlXzwbCCXbKJhJK9STliJDSDSUjdd4EB1 jJLfRhDqxjTev3WY0QqaqMti2; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:44048 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hr5I8-002aB8-Bx; Fri, 26 Jul 2019 13:50:08 -0500 From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/8] Add test for "layout asm" References: <20190721184910.26679-1-tom@tromey.com> <20190721184910.26679-3-tom@tromey.com> <20190726111130.GK23204@embecosm.com> Date: Fri, 26 Jul 2019 18:50:00 -0000 In-Reply-To: <20190726111130.GK23204@embecosm.com> (Andrew Burgess's message of "Fri, 26 Jul 2019 12:11:31 +0100") Message-ID: <871ryck4v4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00583.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> I noticed this pattern a lot in this series, I wonder if using Andrew> 'gdb_assert' would be cleaner? Thanks for mentioning this. I wasn't aware of gdb_assert. I've made this change and I'll send the new series momentarily. I'd like to land this soon, because my next round of TUI refactorings is about ready to send, and it needs the tests. Tom