From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13648 invoked by alias); 27 Oct 2018 17:41:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13637 invoked by uid 89); 27 Oct 2018 17:41:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_05,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=junior, sergio, durigan, sergiodj@redhat.com X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 27 Oct 2018 17:41:36 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 89E21158D0D for ; Sat, 27 Oct 2018 12:41:35 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id GSadgcOe9aSeyGSadguu1o; Sat, 27 Oct 2018 12:41:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KdYAoCkM878bLy+/MntnbfThoJTrOOjLetMKi1xhYfc=; b=B1XD0UfFshzALIRYTLncHVPwVj Fo8Lz6wHN0X8QdRMhvmZ9YqY+F2Zf/E9ud7n+PHfhHlQYM+C2P9YsAA8W0K8zq+VMBoPRJkEGtof7 5zigXoiF9QRDqL5II5e4+jRTZ; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:54090 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gGSad-0015l9-9w; Sat, 27 Oct 2018 12:41:35 -0500 From: Tom Tromey To: Sergio Durigan Junior Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/6] Unify shell-finding logic References: <20181018223100.20693-1-tom@tromey.com> <20181018223100.20693-2-tom@tromey.com> <87tvlhv7o3.fsf@redhat.com> Date: Sat, 27 Oct 2018 17:41:00 -0000 In-Reply-To: <87tvlhv7o3.fsf@redhat.com> (Sergio Durigan Junior's message of "Fri, 19 Oct 2018 19:27:40 -0400") Message-ID: <871s8b9tip.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00654.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> Not sure if I reviewed this one before, but it LGTM (with a very small Sergio> nit below). It also can be pushed independently, IMO. >> +/* Return the file name of the user's shell. */ Sergio> WDYT about explicitly mentioning here that "user's shell" means "the Sergio> SHELL environment variable"? I added some text here. Tom