From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87400 invoked by alias); 19 Jun 2018 06:07:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87386 invoked by uid 89); 19 Jun 2018 06:07:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.179.30) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Jun 2018 06:07:41 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway30.websitewelcome.com (Postfix) with ESMTP id AA15262C1 for ; Tue, 19 Jun 2018 01:07:39 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id V9nQfwj5kbXuJV9ndf9hTL; Tue, 19 Jun 2018 01:07:38 -0500 X-Authority-Reason: nr=8 Received: from 75-166-79-120.hlrn.qwest.net ([75.166.79.120]:36174 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fV9nP-003d6P-Vd; Tue, 19 Jun 2018 01:07:16 -0500 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: GDB 8.2 branch 2018-06-11 Update References: <20180611225629.GA31935@adacore.com> Date: Tue, 19 Jun 2018 06:07:00 -0000 In-Reply-To: <20180611225629.GA31935@adacore.com> (Joel Brobecker's message of "Mon, 11 Jun 2018 15:56:29 -0700") Message-ID: <871sd3joml.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fV9nP-003d6P-Vd X-Source-Sender: 75-166-79-120.hlrn.qwest.net (bapiya) [75.166.79.120]:36174 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-06/txt/msg00471.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> I hinted in a message I sent a couple of weeks ago on this mailing-list Joel> (https://www.sourceware.org/ml/gdb-patches/2018-05/msg00821.html), Joel> we should be getting ready for the next GDB release branch (8.2). I suspect that PR breakpoints/23300 is a regression, and maybe PR mi/23312 as well. I plan to look at 23300 (though I don't mind if someone gets there first). Also I found out that this code in symfile.c: for (auto iter : new_objfiles) gdb::observers::new_objfile.notify (objfile); ... had a bug introduced by commit 4c404b8be6b1d8759eed50366207fc0e2e47d2b1 Author: Tom Tromey Date: Fri Apr 7 15:58:25 2017 -0600 Use std::vector in reread_symbols Previously it read: - for (ix = 0; VEC_iterate (objfilep, new_objfiles, ix, objfile); ix++) - observer_notify_new_objfile (objfile); ... where "objfile" was used in the iteration -- so now the wrong objfile is being passed to the observers. Fixing this is trivial, but I suppose a test case would be good. Maybe the simplest way would be a Python test (so it can hook into the observer) plus a shared library? I am actually not sure. I guess I'm sort of hoping not to write it. Tom