From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Heap-allocate core_target instances
Date: Mon, 07 May 2018 14:26:00 -0000 [thread overview]
Message-ID: <871sen35km.fsf@tromey.com> (raw)
In-Reply-To: <889a13d0-e1c1-02a8-fd99-cdf872e214e7@redhat.com> (Pedro Alves's message of "Sun, 6 May 2018 16:38:48 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> It seems OK to me. The core_target::detach case might be less
Pedro> obvious? I'm adding some comments.
Thanks.
Pedro> Let me know what you think of this version.
Looks reasonable to me, thanks.
Tom
next prev parent reply other threads:[~2018-05-07 14:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 16:22 [PATCH 0/3] Torward multiple simultaneous core instances Pedro Alves
2018-05-03 16:22 ` [PATCH 1/3] Move core_bfd to program space Pedro Alves
2018-05-04 15:41 ` Tom Tromey
2018-05-04 16:09 ` Pedro Alves
2018-05-04 16:46 ` Tom Tromey
2018-05-03 16:22 ` [PATCH 2/3] Eliminate the 'the_core_target' global Pedro Alves
2018-05-04 15:59 ` Tom Tromey
2018-05-03 16:22 ` [PATCH 3/3] Heap-allocate core_target instances Pedro Alves
2018-05-04 16:36 ` Tom Tromey
2018-05-06 15:38 ` Pedro Alves
2018-05-07 14:26 ` Tom Tromey [this message]
2018-05-11 19:40 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sen35km.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).