From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87705 invoked by alias); 7 May 2018 14:26:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87691 invoked by uid 89); 7 May 2018 14:26:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 May 2018 14:26:20 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway31.websitewelcome.com (Postfix) with ESMTP id DC201704F1 for ; Mon, 7 May 2018 09:26:18 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Fh5mf00H4BcCXFh5mfych8; Mon, 07 May 2018 09:26:18 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:48360 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fFh5m-000xnh-Kl; Mon, 07 May 2018 09:26:18 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Heap-allocate core_target instances References: <20180503162234.15371-1-palves@redhat.com> <20180503162234.15371-4-palves@redhat.com> <87in832x9t.fsf@tromey.com> <889a13d0-e1c1-02a8-fd99-cdf872e214e7@redhat.com> Date: Mon, 07 May 2018 14:26:00 -0000 In-Reply-To: <889a13d0-e1c1-02a8-fd99-cdf872e214e7@redhat.com> (Pedro Alves's message of "Sun, 6 May 2018 16:38:48 +0100") Message-ID: <871sen35km.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fFh5m-000xnh-Kl X-Source-Sender: 97-122-176-117.hlrn.qwest.net (pokyo) [97.122.176.117]:48360 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00168.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> It seems OK to me. The core_target::detach case might be less Pedro> obvious? I'm adding some comments. Thanks. Pedro> Let me know what you think of this version. Looks reasonable to me, thanks. Tom