From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88053 invoked by alias); 12 Feb 2018 16:45:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88044 invoked by uid 89); 12 Feb 2018 16:45:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Feb 2018 16:45:46 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 1F4066093 for ; Mon, 12 Feb 2018 10:45:43 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id lHEde2OlkBUMKlHEde4gBd; Mon, 12 Feb 2018 10:45:43 -0600 Received: from 174-29-33-254.hlrn.qwest.net ([174.29.33.254]:47322 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1elHEc-001k0b-Rs; Mon, 12 Feb 2018 10:45:42 -0600 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Make "bt N" print correct number of frames when using a frame filter References: <20170423160446.17062-1-tom@tromey.com> <87tw43d1ew.fsf@bapiya> <87tvzjx6pg.fsf@pokyo> Date: Mon, 12 Feb 2018 16:45:00 -0000 In-Reply-To: <87tvzjx6pg.fsf@pokyo> (Tom Tromey's message of "Sat, 30 Sep 2017 14:38:35 -0600") Message-ID: <871shqtave.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1elHEc-001k0b-Rs X-Source-Sender: 174-29-33-254.hlrn.qwest.net (pokyo) [174.29.33.254]:47322 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-02/txt/msg00172.txt.bz2 >>>>> "Tom" == Tom Tromey writes: >>>>> "Tom" == Tom Tromey writes: >>> PR python/16497 notes that using "bt" with a positive argument prints >>> the wrong number of frames when a frame filter is in use. Tom> Going through my un-reviewed patches today. Tom> Ping for this one. Tom> I don't think this was ever approved. Tom> There's a follow-up as well (to change the enum to use Tom> DEF_ENUM_FLAGS_TYPE), but that one was OK'd; but still pending since it Tom> touched the same code as this patch. This is still pending review. Some discussion here: https://sourceware.org/ml/gdb-patches/2017-07/msg00200.html Original patch here: https://sourceware.org/ml/gdb-patches/2017-04/msg00630.html I have a branch with this patch plus the previously-approved patch to change frame_filter_flags to use DEF_ENUM_FLAGS_TYPE, so if/when this one is ok'd, both will go in. thanks, Tom