From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80674 invoked by alias); 12 Oct 2017 21:07:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80267 invoked by uid 89); 12 Oct 2017 21:07:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:317 X-HELO: outbound-ss-1812.hostmonster.com Received: from gproxy1-pub.mail.unifiedlayer.com (HELO outbound-ss-1812.hostmonster.com) (69.89.25.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Oct 2017 21:07:37 +0000 Received: from cmgw3 (cmgw4 [10.0.90.84]) by gproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id 9ACC8175D4F for ; Thu, 12 Oct 2017 15:07:35 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id Ll7Y1w00b2f2jeq01l7bZW; Thu, 12 Oct 2017 15:07:35 -0600 X-Authority-Analysis: v=2.2 cv=H76r+6Qi c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=02M-m0pO-4AA:10 a=awCqPkcWBbRKjik_kC4A:9 Received: from 184-96-33-178.hlrn.qwest.net ([184.96.33.178]:34932 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1e2khY-0031la-8S; Thu, 12 Oct 2017 15:07:32 -0600 From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , Simon Marchi , Subject: Re: [RFA 4/7] Use ui_out_emit_tuple in disasm.c References: <20170909153540.15008-1-tom@tromey.com> <20170909153540.15008-5-tom@tromey.com> <79955c67-567b-7bc9-c238-9245c9ab1911@ericsson.com> <6226d3be-17c7-aa69-bdbf-efe11ffc1b5f@ericsson.com> <8760bkqrf4.fsf@tromey.com> Date: Thu, 12 Oct 2017 21:07:00 -0000 In-Reply-To: <8760bkqrf4.fsf@tromey.com> (Tom Tromey's message of "Thu, 12 Oct 2017 10:09:19 -0600") Message-ID: <871sm8qdm8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1e2khY-0031la-8S X-Source-Sender: 184-96-33-178.hlrn.qwest.net (pokyo) [184.96.33.178]:34932 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-10/txt/msg00326.txt.bz2 Tom> I think I'll just back out this particular change. Tom> The way disasm code uses cleanups is very hard to untangle. It turns out that with gdb::optional, you don't have to untangle it. I'm testing a patch to convert the rest of disasm.c away from cleanups. Tom