From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125471 invoked by alias); 6 Oct 2016 02:52:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125454 invoked by uid 89); 6 Oct 2016 02:52:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Thu, 06 Oct 2016 02:52:36 +0000 Received: (qmail 5597 invoked by uid 0); 6 Oct 2016 02:52:34 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy6.mail.unifiedlayer.com with SMTP; 6 Oct 2016 02:52:34 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id s2sU1t00m2f2jeq012sXs0; Wed, 05 Oct 2016 20:52:32 -0600 X-Authority-Analysis: v=2.1 cv=Pa5s2ERd c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=20KFwNOVAAAA:8 a=NFiX1zC5Kb-lFASG4MEA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 71-218-192-86.hlrn.qwest.net ([71.218.192.86]:32986 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1brynO-0004cR-CB; Wed, 05 Oct 2016 20:52:30 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 09/22] Remove make_cleanup_restore_current_ui References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-10-git-send-email-tom@tromey.com> <90ae8364-df1e-d322-269e-ffa44b57d475@redhat.com> Date: Thu, 06 Oct 2016 02:52:00 -0000 In-Reply-To: <90ae8364-df1e-d322-269e-ffa44b57d475@redhat.com> (Pedro Alves's message of "Thu, 6 Oct 2016 02:24:29 +0100") Message-ID: <871szufatv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1brynO-0004cR-CB X-Source-Sender: 71-218-192-86.hlrn.qwest.net (bapiya) [71.218.192.86]:32986 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00102.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> +class switch_thru_all_uis >> { >> +public: >> + >> + switch_thru_all_uis () : iter (nullptr), save_ui (¤t_ui) >> + { >> + iter = ui_list; Pedro> This initializes "iter" twice. Thanks. Apparently I already found that one and fixed it on my branch, because now I see: + switch_thru_all_uis () : m_iter (ui_list), m_save_ui (¤t_ui) + { + } + Tom