From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10722 invoked by alias); 15 Dec 2014 03:44:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10707 invoked by uid 89); 15 Dec 2014 03:44:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 15 Dec 2014 03:44:24 +0000 Received: from svr-orw-fem-02x.mgc.mentorg.com ([147.34.96.206] helo=SVR-ORW-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Y0Ma5-0004PK-M5 from Yao_Qi@mentor.com ; Sun, 14 Dec 2014 19:44:21 -0800 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.3.181.6; Sun, 14 Dec 2014 19:44:21 -0800 From: Yao Qi To: Doug Evans CC: Subject: Re: [PATCH] Buildsym cleanups: more docs, more uniform set-up and tear-down References: Date: Mon, 15 Dec 2014 03:44:00 -0000 In-Reply-To: (Doug Evans's message of "Sat, 13 Dec 2014 16:14:31 -0800") Message-ID: <871to1vapo.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00362.txt.bz2 Doug Evans writes: Some comments on indentation. > /* Restart compilation for a symtab. > + CUST is the result of end_expandable_symtab. > + NAME,START_ADDR are the source file we are resuming with. Space after comma is missing. >=20=20 > /* Subroutine of end_symtab_from_static_block to simplify it. > Handle the "no blockvector" case. > - When this happens there is nothing to record, so just free up > - any memory we allocated while reading debug info. */ > + When this happens there is nothing to record, so there's nothing to d= o: > + memory will be freed up later. > + This function is kept to have a place to document the issues. */ >=20=20 > static void > end_symtab_without_blockvector (void) > { > - /* Free up all the subfiles. > - We won't be adding a compunit to the objfile's list of compunits, > + /* Note: We won't be adding a compunit to the objfile's list of compun= its, > so there's nothing to unchain. However, since each symtab > is added to the objfile's obstack we can't free that space. > We could do better, but this is believed to be a sufficiently rare > event. */ > - free_buildsym_compunit (); > } end_symtab_without_blockvector is empty, so remove it? --=20 Yao (=E9=BD=90=E5=B0=A7)