From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26383 invoked by alias); 10 Oct 2014 16:38:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26302 invoked by uid 89); 10 Oct 2014 16:38:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,LIKELY_SPAM_BODY,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=no version=3.3.2 X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 10 Oct 2014 16:38:49 +0000 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s9AGcja8012502 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Oct 2014 16:38:45 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s9AGciOa007363 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 10 Oct 2014 16:38:45 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s9AGchvA016682; Fri, 10 Oct 2014 16:38:44 GMT Received: from termi.oracle.com (/10.175.211.52) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 10 Oct 2014 09:38:43 -0700 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/9] New gdbarch functions: dtrace_probe_argument, dtrace_probe_is_enabled, dtrace_enable_probe, dtrace_disable_probe. References: <1411724905-31234-1-git-send-email-jose.marchesi@oracle.com> <1411724905-31234-5-git-send-email-jose.marchesi@oracle.com> <874mvmupep.fsf@redhat.com> Date: Fri, 10 Oct 2014 16:38:00 -0000 In-Reply-To: <874mvmupep.fsf@redhat.com> (Sergio Durigan Junior's message of "Thu, 02 Oct 2014 17:34:22 -0400") Message-ID: <871tqfev6n.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00257.txt.bz2 > diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh > index 2a8bca8..0458134 100755 > --- a/gdb/gdbarch.sh > +++ b/gdb/gdbarch.sh > @@ -944,6 +944,21 @@ M:int:stap_is_single_operand:const char *s:s > # parser), and should advance the buffer pointer (p->arg). > M:int:stap_parse_special_token:struct stap_parse_info *p:p > > +# DTrace related functions. > + > +# The expression to compute the NARTGth+1 argument to a DTrace USDT probe. > +# NARG must be >= 0. > +M:void:dtrace_probe_argument:struct parser_state *pstate, int narg:pstate, narg This function is responsible for parsing the argument, right? I'd prefer if you named it "dtrace_parse_probe_argument". WDYT? Yes, I agree, that name is better. Changed in the patch.