From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec104.isp.belgacom.be (mailsec104.isp.belgacom.be [195.238.20.100]) by sourceware.org (Postfix) with ESMTPS id F386D384189E for ; Sat, 4 Jun 2022 17:45:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F386D384189E X-ExtLoop: 1 X-IPAS-Result: =?us-ascii?q?A2BSAQAJmpti/yFRiNkNTYEJCYZAhE6REJ5iCwEBAQEBA?= =?us-ascii?q?QEBAQlCBAEBhQIChUcmOBMBAgQBAQEBAwIDAQEBAQEBAwEBBgEBAQEBAQYEA?= =?us-ascii?q?YEbhS+CeykBg2MBAQEBAyMPAUYQCw4GAQMCAiYCAlcGARKxAHqBMYEBhG6DK?= =?us-ascii?q?4FlgREshz6DCYQbN4FVRIQ/PogagmUElwkdOwMcLTQSgSFxAQgGBgcKBTIGA?= =?us-ascii?q?gwYFAQCExJTHQISBQcKHA4UHCQZDA8DEgMRAQcCCxIIFSwIAwIDCAMCAyMLA?= =?us-ascii?q?gMXCQcKAx0IChwSEBQCBBMeCwgDGR8sCQIEDgNFCAsKAxEEAxMYCxYIEAQGA?= =?us-ascii?q?wkvDSgLAwUPDwEGAwYCBQUBAyADFAMFJwcDIQcLJg0NBBwHHQMDBSYDAgIbB?= =?us-ascii?q?wICAwIGFwYCAnEKJg0IBAgEHB0lEAUCBzEFBC8CHgQFBhEJAhYCBgQFAgQEF?= =?us-ascii?q?gICEggCCCcbBxYZHRkBBV0GCwkhHCkLBgUGFgMjcQUKPg8pNTY9BiIBHZgXc?= =?us-ascii?q?VqBecIgNAeDUYE9BgyeQTGoW5ZoIKcTgXiBfm2DO1EojleOG3M7AgYBCgEBA?= =?us-ascii?q?wmQFAEB?= IronPort-PHdr: A9a23:zYRfURfGYhFeslbw2e6ZDkLFlGM+7dnLVj580XLHo4xHfqnrxZn+J kuXvawr0AWSG9SLoKsd1aL/iOPJYSQ4+5GPsXQPItRndiQuroEopTEmG9OPEkbhLfTnPGQQF cVGU0J5rTngaRAGUMnxaEfPrXKs8DUcBgvwNRZvJuTyB4Xek9m72/q99pHNbQhEnj6wbLB9I BmrsAnct9QdjJd/JKo21hbHuGZDdf5MxWNvK1KTnhL86dm18ZV+7SleuO8v+tBZX6nicKs2U bJXDDI9M2Ao/8LrrgXMTRGO5nQHTGoblAdDDhXf4xH7WpfxtTb6tvZ41SKHM8D6Uaw4VDK/5 KpwVhTmlDkIOCI48GHPi8x/kqRboA66pxdix4LYeZyZOOZicq/Ye94RWGhPUdtLVyFZAY2yc osBAfQfMOhWrYb9qUcBohWxCgejH+7v1jxFi2Xq0aEmyeksEwfL1xEgEdIUt3TUqc34Or0SU eC0yKnIzC3Db+tI1jzg6IfHaAohofaVXbJtcMre11MvFxjYhViXsYzlPzKV1uAMs2iD9+pvS /ijimA9pAFrpTiv39osiojXiYIP0VDJ7j55wIU1JN2+VkF7fcSoH4BOuCyDMYZ9X8wtTX1yt ikg1r0GpYC0fDIMyJk/wxPTd/yJfpSJ7x/iW+idPzh1inJhdb+whRu/80utxO3hWsSozVpHr zRIn9nIu30RyhDe98eJRPVg8kqvxzqC0wbe4fxHL0AsjafXNYMtz7wqmpYOv0nOHzX6lUbrg KOMeEgp9O6l4Pn9bLr8vJ+TLYp0hxn7MqQph8OwH/w1MhMLX2iH4eS806Dj/VHhTLVKkPI2l q7ZvYjeKsgGoqO1HRVZ3psi5hu8FTuqzc4UkWQDIV1DYB6Hjo7pNE/SIP3gE/uznlahnC12y /3IP7DtGJbAImXZnLrvc7tx80tcxxAyzdBb6ZJUELYBIPfrV0/ptNzYDxs5Mw2sw+b/Ftpxz I0fVniVAq+eKaPSrF6I6fw1I+mXf4IVozX9Kvgj5/HwkX81g0QScrex0ZsRc3+3Bu5mLFmBY XrwntcBFn8HswQmQOzwlFKCSSJTZ2q1X68k/DE0Ep6mDYLCRo+xnrOMxyi7HphMaWBHDlCAC 2vnd4KBW/sUciKdPtdhkiAYVbimU4IuyxWutA77yrd8IerU/DAYuYjk1Nhv6O3fjQsy+iBsD 8SBz2GNSHl5nmwVSDAtxax/uVZyykuf3qh4nfNYDsde5+hOUgcnL57T0/J1Ct7oVQLbYNiFU lGmQs+pAWJ5ctVk5tYSfw5HGt6vxkTZ1javArQYv7OODZ0wtKnb2i61b+t5yj703bMsk0IlQ 8oHYWCih7xX+A7OQYnTnBPKubytcPEk3C/J9X+bwCKxtVtfSRNxXL/eFSQHZkrSrMzh6wXdR qWpEKkmPxFa4dWBO61HdpvjgAMVF7/YJN3CbjfpyC+LDhGSy+bJNdKyE1g= IronPort-Data: A9a23:0J96Ha7hynF9wseBxYRDAQxRtHDGchMFZxGqfqrLsTDasY5as4F+v mAfWzrSM6yIMTb3KdBzPI/jpksBsMXXxoMwSFFkrXgzZn8b8sCt6fZ1jqvT04J+CuWZESqLO u1HMoGowPgcFyOa/lH0WlTYhSEUOZugH9IQM8aZfHEoLeNYYH1500g7xbZl2tcAbeWRWmthh /uj+6UzB3f4g1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJM53yZWKEpfNatI88thW6 Ar05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkSvqkAqm8A87ko0HMQhagR9lyiKppd0x vlTld+0dyR2HaKZzYzxUzEAe81/FZ4fqeWBeCbv95XVlhzzG5fu6683UwdvZtNeqr8xWjomG f8wcVjhajibh+OywaqjR69zj94kNdTqMZkEkmpj3DfUEbAsTPgvRo2TvoYIhW9o3ZEm8fD2X PIlUBlOdgv6WCJ1MFowLMMzmOCqvyyqG9FfgBfPzUYt2EDJxRB00bPgGNXQc92OA85Smy6wq 2bH7Uz2BAxcM8aQoRKK/njpnubTliP2Q6oJE6Ci/fN1iUeegGsJB3UruUCT+qL/2hf7AokBb hZNpWwnobM2sUC6SJ/8RAX+qnOAsRcXXN8WGeBSBByx95c4Kj2xXgAsJgOtovR/3CPqbVTGH WNlUz8k6fKDfVFVpb+gGm+okA6P IronPort-HdrOrdr: A9a23:HkFnQqvKvD8lSAzOEztaa7o77skDfdV00zEX/kB9WHVpmwKj+P xG+85rsSMc6QxhO03I9urvBEDtex7hHNtOgLX5Xo3SOTUO2lHCEGgK1+KL/9SjIU3DH4Vmv5 uIHZITNDS9NykZsfrH X-IronPort-Anti-Spam-Filtered: true X-ProximusIPWarmup: true Received: from 33.81-136-217.adsl-dyn.isp.belgacom.be (HELO [192.168.1.19]) ([217.136.81.33]) by relay.proximus.be with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2022 19:45:53 +0200 Message-ID: <8731d516b74f787673ac6e2ece5b4f430a09165b.camel@skynet.be> Subject: Re: [RFA] Show locno for 'multi location' breakpoint hit msg+conv var $bkptno $locno. From: Philippe Waroquiers To: Matt Rice , Eli Zaretskii Cc: "gdb-patches@sourceware.org" Date: Sat, 04 Jun 2022 19:45:53 +0200 In-Reply-To: References: <20220417155311.3487509-1-philippe.waroquiers@skynet.be> <874988bef430ed6e239e74a4a94eb2ad13175f4a.camel@skynet.be> <1001e780cc1d9f7a85923d6707bf17f063b8da90.camel@skynet.be> <24da89de-d36f-53c7-fe69-a8c7a1c38caf@redhat.com> <83o7z9aqvm.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jun 2022 17:45:56 -0000 On Sat, 2022-06-04 at 17:27 +0000, Matt Rice via Gdb-patches wrote: > On Sat, Jun 4, 2022 at 6:23 AM Eli Zaretskii via Gdb-patches > wrote: > > > > > Date: Fri, 3 Jun 2022 13:40:00 -0700 > > > From: Keith Seitz via Gdb-patches > > > > > > I looked up the history of this patch a bit to understand the motivation > > > for querying co-workers... I see Eli commented in the original April > > > discussion: > > > > > > > I'm not sure everyone will want to see the likes of > > > > > > > >  Thread 1 "foobar" hit breakpoint 10.42, some_func () at ... > > > > > > > > But that's MO; I'd be interested in opinions of others. > > > > > > Well, I'm not a global maintainer, but I'll chime in with my opinion, > > > if everyone will permit me. [Ha! You're already reading it!] > > > > > > I don't think it is a big deal to see ".42" in the output. Far more > > > irritating is not knowing exactly which of the many locations it hit. > > > I've always felt this was akin to ambiguous output by GDB. "You hit > > > breakpoint X." Oh, wait, that's one of fifty different real breakpoints. > > > > We show the source line where the breakpoint breaks right after this, > > so at least some of the ambiguity is resolved by that. > > My thoughts are that whether or not source line resolving ambiguity > printing the breakpoint locno > may be useful for instance, `disable 10.42` to disable that location, > you wouldn't have to do > info break and look through the what or address column of `info b`. Yes, that was the main trigger to add this change. As you indicate, if the breakpoint is in an inlined function, then all locations have the same source and line nr and the only differentiating aspect is then the address. Philippe