From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 6547F384AB41 for ; Wed, 8 May 2024 15:48:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6547F384AB41 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6547F384AB41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715183338; cv=none; b=xZEe1WJlES54gnUbUY3ZoaXBgsaAS8d/CQ39QUnvyYQ4PDY8JVmvPwY9FKQAKlGO6SUYIgUVNW/FuNnlaJrCqtPQr4cneTCakQuEOIYxENQMw3yp++gMY9J9R93mlNo9lMs6g+CdIbT9q7roMSVouiCo2Y3U+dhdgs27naxWavQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715183338; c=relaxed/simple; bh=c5xYRYXdcWjt3QPm3MF6sItgYzPi/pLkpMDQ6dUFEy4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=NlGQXnHmGkRrgDShf4EiR9DjB5BAvTowsJZM6eldEwGXIclvOtjwBQiprpLSK8s78QJP+a4mc1eGqE2/BB5j2AWwUxL13n6egWgGGFYhBDpqKyrLpxu7bbt7QuAy2Vx/39kI3KRP5eaEKNp7kcqbTtC7emU2MHNoVQM5FfuGK0c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5005a.ext.cloudfilter.net ([10.0.29.234]) by cmsmtp with ESMTPS id 4O8js4Ge2SLKx4jXMsXQyQ; Wed, 08 May 2024 15:48:56 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 4jXLsGnyQYakK4jXMsvENl; Wed, 08 May 2024 15:48:56 +0000 X-Authority-Analysis: v=2.4 cv=a4T79lSF c=1 sm=1 tr=0 ts=663b9ee8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=TpHVaj0NuXgA:10 a=Qbun_eYptAEA:10 a=RtkggBvCAAAA:8 a=zstS-IiYAAAA:8 a=F7mGFo5QaWH8oqcnzIsA:9 a=S_HVFEA2qnQA:10 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=k/pvYuZnn58+xOqgltTTZV6vvz7imqg9Q55uVcEPiR0=; b=HU2e+YHVE4cJltERLwkxhYaCFD 3D7Ek/PMa6BOAmuL9DsbnHflGldWVcRmWR9aXw7wsvzq2deQosl6IH0T4i0bPe3wpieEtrrtqQKl2 /s3Q3M/u/De71UMetpaxcVOac; Received: from 97-122-86-252.hlrn.qwest.net ([97.122.86.252]:51482 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1s4jXL-000vCD-1i; Wed, 08 May 2024 09:48:55 -0600 From: Tom Tromey To: Dmitry.Neverov Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v3][PR symtab/30520 1/4] gdb/symtab: check name matches before expanding a CU In-Reply-To: <87le4kmtcw.fsf@lubuntu2.mail-host-address-is-not-set> (Dmitry Neverov's message of "Wed, 08 May 2024 13:32:47 +0200") References: <20240506150920.1220092-1-dmitry.neverov@jetbrains.com> <87edada70o.fsf@tromey.com> <87le4kmtcw.fsf@lubuntu2.mail-host-address-is-not-set> X-Attribution: Tom Date: Wed, 08 May 2024 09:48:54 -0600 Message-ID: <8734qs5mop.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.252 X-Source-L: No X-Exim-ID: 1s4jXL-000vCD-1i X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-252.hlrn.qwest.net (murgatroyd) [97.122.86.252]:51482 X-Source-Auth: tom+tromey.com X-Email-Count: 30 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfGdBTnwME1AeTVkFTZorqmgDpphj7+8C9OZGr9vS/J6KDIjkhXRzS2TClebqfgJ0RR7n/JlBxVybS/EYkwoqN7badnWY9EKhmlQ/m6dKX/fhbuEyjXuQ AU5q69PxjqNxw3Fckg08SdhITsce0JnFfDtlB6uzHLu3e5va1g9Uxa8Dtgt0zMS2xXDb3GpMOefbiuDevETlBUyKLiuEdZsNT/A= X-Spam-Status: No, score=-3014.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Dmitry" == Dmitry Neverov writes: Dmitry> Tom Tromey writes: Dmitry> + symbol_name_matcher_ftype *name_matcher Dmitry> + = lang_def->get_symbol_name_matcher Dmitry> + (last_segment_lookup_name); >> >> This also looks weird by gdb rules. Dmitry> Do I understand correctly that it should look like this: I'd write: symbol_name_matcher_ftype *name_matcher = lang_def->get_symbol_name_matcher (last_segment_lookup_name); Sometimes wrapping is unavoidable but there's also symbol_name_matcher_ftype *name_matcher = (lang_def->get_symbol_name_matcher (last_segment_lookup_name)); Dmitry> How do I send an updated patch? I've read the Contribution Checklist, Dmitry> but didn't find the answer. Do I amend the commit and 'git send-mail' it Dmitry> again with proper '--in-reply-to'? I just re-send it with --reroll-count=... I don't normally worry about in-reply-to. Not sure, maybe I should? For series I often use b4 these days, though I've also been bitten by its bizarre behavior, so I'm not sure I can really recommend it. Tom