From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 79B91385842E for ; Mon, 22 Jan 2024 10:29:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 79B91385842E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 79B91385842E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705919385; cv=none; b=ju/hwiw5BVcfAiekMEgjRGiSYjGERLZtNlyUE5wGqgi5lVqOZWNKH1jD8ylY8zCBPm4XZhZ7PjzJT7XD84pgBp762xHLvEaiBMgjD3Ju9c53NatRfd2ZDQitIbJcUDlp1PKLaQWIBGuvXIATGjD7hQ0ZQhwCX07YUdlUO+w8vqY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705919385; c=relaxed/simple; bh=YQ+BTfUf4LQh23UtjzIAf4Owdg92+48LVg/ggPAcv04=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WgaKUI/fx0VZnb9iWt58JsPO2wUtB2dEJ/M42/GvYxzjnMiRF3L5eDHqQcMBcTvcSRxBCc1RZf/fbjFvuQOhBewoC+icb6vSURZ7jTQobLioeooTDuPH/gPz/q/n9ld7c2przqKdt5bsrw5RqGhq8GrHCvuVYlwPt7m9k76UiQs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705919384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=07V5Vc8/bo8M4xkH5RKJNgabtc5Uiy8aDwl5c+JIBBE=; b=FeDPQMct7Dd3Fig29Kr63euaVwyRl7gPgMrFFrn0N/7KYRw1pyQj/HU3hdgk4wVH6Lb4Uf GpyFZO+TW/wT9K014stDvLR9ATQzL3J/FeSZ/tOjkJOFEMlz7lt86hUtS9CC+hZ5ZVP3zG XQ0YfXZXxK4sFh4vHRRzy9T2xbDBlsk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-7FdF-XpoMoeTKVXEhUCbVA-1; Mon, 22 Jan 2024 05:29:42 -0500 X-MC-Unique: 7FdF-XpoMoeTKVXEhUCbVA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40eaedb4446so4498655e9.0 for ; Mon, 22 Jan 2024 02:29:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705919381; x=1706524181; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=07V5Vc8/bo8M4xkH5RKJNgabtc5Uiy8aDwl5c+JIBBE=; b=ayedHz3la3yoNfvmPJ3mN3rS7nlPVrt23HHYEmvaHKj30vEGlCxt/ZURgLAVAog1QP /Ix8TCs/Iyx53eU+16fgfyBC1ZWolg08V2q54CBWZMbQok+tYJwxGto3FbrIlNRSzY/F kWhM+F2HHO5lVBJsCmPTs7A2A4L9j2sHePTrmsCxafKJL8jKxPOMWrmFbrIQmg/jtUHC v3YFSRubkx5VV1lHmOVvxyBTThPNzh1+i1rk7CLNcw09tOrp9k1990blbxo4u8oJNz1i R/OZirmb2Wvna0SbVH6P0wsY5em2OL0836AsqYXyNK9grMJmovXV8eGdseiggd7uNrCZ BctQ== X-Gm-Message-State: AOJu0YxDa8EGfaRTrOgkREbVWNIzv3LQRwkd2kPuRG5vRjMHPNC8D3h9 bhhonvXdeuPKDI2sFP7U5fGXexlwE7GEJ0VUsfVufL5gg5b66felm77Wo92kTsnntyaSTT3alZS p0COFBfqWc5cq+ifbbwOTW4sI0CGN4Ar4Mcr4Cz5awenel6aAVgXDMMB9xB+hEiULj7U= X-Received: by 2002:a05:600c:a01:b0:40e:a323:4fcb with SMTP id z1-20020a05600c0a0100b0040ea3234fcbmr2077818wmp.116.1705919381452; Mon, 22 Jan 2024 02:29:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IEVLXcXI6lJyyzkJFGgevC9cLB4gBa1MHzu+A48u+/nkw9rmgNrKpjEDzqodKanqjGdzK85qA== X-Received: by 2002:a05:600c:a01:b0:40e:a323:4fcb with SMTP id z1-20020a05600c0a0100b0040ea3234fcbmr2077811wmp.116.1705919381183; Mon, 22 Jan 2024 02:29:41 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id ek15-20020a05600c3ecf00b0040e8e358f82sm15565749wmb.19.2024.01.22.02.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 02:29:40 -0800 (PST) From: Andrew Burgess To: Eli Zaretskii Cc: gdb-patches@sourceware.org, m.weghorn@posteo.de Subject: Re: [PATCH 00/16] Inferior argument (inc for remote targets) changes In-Reply-To: <8334urrnnr.fsf@gnu.org> References: <835y02phor.fsf@gnu.org> <87bk9f62tx.fsf@redhat.com> <8334urrnnr.fsf@gnu.org> Date: Mon, 22 Jan 2024 10:29:40 +0000 Message-ID: <8734up64q3.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Eli Zaretskii writes: >> From: Andrew Burgess >> Cc: gdb-patches@sourceware.org, m.weghorn@posteo.de >> Date: Sat, 20 Jan 2024 22:46:02 +0000 >> >> The question makes perfect sense. >> >> My hope is that the situation on Windows is no better or worse than it >> ever was. >> >> I'm reluctant to start writing documentation saying feature X does or >> does not work on Windows and why though as I don't have access to a >> Windows machine on which I can test any of this. > > How about saying in the manual that for the embedded newlines to work, > the inferior should be started via a Posix shell? This should be > enough to hint Windows users this will not work for them. That makes sense. I other feedback to address, so I'll add some suitable words in this area and draw your attention to it on V2. Thanks, Andrew > >> I believe it's already possible today to inject newline characters via >> the Python API. Maybe the window-nat.c code should be checking for >> invalid characters and throw an error if the user tries to start an >> inferior. > > If doing that produces some error message from the inferior or the > APIs we use to start it, that should be enbough. > >> I agree that platform specific limitations should be documented. I'm >> willing to help however I can to get that done. But I'm a little >> uncomfortable trying to document something I can't test. I'll see if I >> can source a Windows laptop, maybe I can build/test in that setup. > > Maybe someone else can test that, and we could then amend the > documentation as needed? IOW, I see no reason to delay installing > your patch series due to this. > > Thanks.