From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id 9B2DD385803B for ; Thu, 14 Dec 2023 18:52:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B2DD385803B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9B2DD385803B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702579940; cv=none; b=KfBQByqoc3Kyi4sddAq3l8unGDax1i7oHsFVGL5IzeL8dsY8vA3seTzm7eO1jeuL+KL4zbK1KU4xTRoka3CQjfYE+Oq74uGSUnckFRUGfzktb4dl80HVPo/nHc4MF6rQ0TjgorTbc2NwoPMb1LvtEv5DaFJ0gphM8IkDsTq8hsc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702579940; c=relaxed/simple; bh=JKhYMT4PmEHHwtgHc4uVI3bNWAeKUGWmXJj6wqk1NJs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UZIHhd5iCVDKybNgklSGnIor7GnMVnKLQvkUgqPLoUFmDZ9g6grk8CxO2TaQYk648+XgSuKo/zeMT5WnjYIwTS04A5NFNW2OxUBI651Ajh/KJ67wZGtCk+lsuMuH4Tuc4RmdSEeeang3oIN1vtpvnP3sL38ItZP2mzKyxTydPAM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-7b435966249so366266239f.0 for ; Thu, 14 Dec 2023 10:52:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1702579937; x=1703184737; darn=sourceware.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=8nSBk0dWb06NXp4Y0tqD7MB7XL66RLpEt+KMW4RE5cE=; b=e8f3woMkFgHU5bAf93KIxRoeLuesGDUapIpoYMDAsFFZ4AOBbwzIyYQc4ZHkHU80nd nA79OpT7K+iI69rzQVbiBa61BsROQKA3yIMkaO44hMIPpL96m/o+m1OUbJM8VbjmjovZ vO/Rsp0g0r/qA3Mfc3NoLibwPT8kuTalN/0cNX77jxutiCVNfWV8L2Txy1UNbJF1jpEt yBqobEnRQLLYMOqIiQdwnssysX6SQ/+LCaqNMOW8lXqGcdLwlIft8/eIQ9iXlm/++XBn LBfJ1rZdvEnNGwwNIAiywjWbUncM5l2RjgUcXnz/K/u+z1gQldyfq1cj+/F+IbOoXFUa 3/2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702579937; x=1703184737; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8nSBk0dWb06NXp4Y0tqD7MB7XL66RLpEt+KMW4RE5cE=; b=oAIFX+VWvV9D3de1odHGeRbGtfBhu33c5QO7uabjS+MHpL5j4gT8bCm71+MQLzUg1L 1mXfiKdhe+kGIUh4uRvSxgS6LXy/v+gWKt7lt6v1UrMmlmEOD9+CQV8I2Crtnhfje5ys tbITbZOiEs9KBk+GXytv0gl2C+xbaGNbo9Kq9mJMTS8Cbbe3hamIk0dSeWq0RvsG44MI FF2THWPxnl4vF+crrE09RqHJF2m4JijSZL9oJGqCHaskumm814c1iAtORf5Sdj6LOQ3v OFwgkGCBAiSaeYtHw8qmZgatcbrU4Ij3W6CNuM+pIejsA43M/FiVDEvjinOKo8TSMpqj uPUQ== X-Gm-Message-State: AOJu0YxMeR4f+28mKTQBlzjS/5BQHzCCeNhPhM6EW/Cyyz9Jslzy6Cfh OhymksgvB0ppJq0M0gYaaAYe8r/oSsybmIg1wec= X-Google-Smtp-Source: AGHT+IGKjQ9mCZZOCyS1hws9KrrZ8ev9Rf3oYU4FhdNhbjRyMdX87G+Pxc+YLS9m6idl06hzA03X3g== X-Received: by 2002:a05:6e02:1686:b0:35f:72ef:1b98 with SMTP id f6-20020a056e02168600b0035f72ef1b98mr4849562ila.53.1702579936837; Thu, 14 Dec 2023 10:52:16 -0800 (PST) Received: from murgatroyd (71-211-161-25.hlrn.qwest.net. [71.211.161.25]) by smtp.gmail.com with ESMTPSA id q27-20020a056638041b00b00468f1305e4esm3643906jap.21.2023.12.14.10.52.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:52:16 -0800 (PST) From: Tom Tromey To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] Avoid exception from attach in DAP References: <20231212-dap-no-test-exceptions-v1-0-af0e33f10093@adacore.com> <20231212-dap-no-test-exceptions-v1-3-af0e33f10093@adacore.com> <87o7eu3vri.fsf@adacore.com> X-Attribution: Tom Date: Thu, 14 Dec 2023 11:52:15 -0700 In-Reply-To: <87o7eu3vri.fsf@adacore.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Wed, 13 Dec 2023 17:36:01 +0100") Message-ID: <8734w4aa74.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "K=C3=A9vin" =3D=3D K=C3=A9vin Le Gouguec wri= tes: K=C3=A9vin> Nit: I'd find ... K=C3=A9vin> slightly more legible (less nesting; easier to understand that = the K=C3=A9vin> purpose of each branch is to set obj["reason"]), even if it mea= ns K=C3=A9vin> repeating event.details["reason"]. Really not a huge deal thou= gh, good K=C3=A9vin> to go as-is for me. I like it, I've made this change here. Tom