From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by sourceware.org (Postfix) with ESMTPS id 64825386184F for ; Wed, 6 Dec 2023 17:01:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 64825386184F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 64825386184F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701882112; cv=none; b=g1fHAH/aMpNQPt5J4qa6WnRX3WT96KRK35hIMmLpJNzZaHnoSgQXN/wV1yMDvycZE8rekB1yCP2sxFgvCrkZHtqzxFqNJl2MFRausaoll9I+oCRUJtZ7pdRfOcTlMHTUGkenMl6DxrghXZqDptqGI+6He5BO1kDxM8XuHrvNFW0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701882112; c=relaxed/simple; bh=bFapV4LJ8aJ2ZxOKNOnzH3xQCrctrp9FZUuDQ8sXE+k=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vKigQSlp4Zw9BFzlmREjALTC+f5So5XF9PNCTaoKyA7mfh6RFxRHPPGxepS8WF8EIKHSnC0UrJAa7mpebv9MrI+LI9IDWq26KSb6LtBywj6Z425xuRUttx8jTNO9RbM5dnkqWEc+aKFH1DEhWmGrIRQdEzIiNHydEjrRYFYaTP0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2f.google.com with SMTP id ca18e2360f4ac-7b45c382507so69478339f.0 for ; Wed, 06 Dec 2023 09:01:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1701882104; x=1702486904; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=g43u5jjhfQO9PY3VWTnpZWIR/gdaK4dtnhkglk2X8mA=; b=VO18Uer7U5ib7ZOKH5UeH/5EB7S+xXHpFqmXH3jX2UZR/OVHvUrbkpUtROb+YI91jA ZQsQXYooKy5iDYb0aRLgOxhQMx4Y0qDLWcwaFJQewy4KmGBHjyGE7AHge0FpsjmyvUje Gd8aFDkrARTtjVoDODiE0PoMoLBnn8HGmr1bYHx6b0ZKM2BjLf4vWnoR564SjvsS+S6U tgXv71icnzAB/nuIMtjid1XO1XlxyoBLJTtOqCAEfpaFMIcVcUE/Lj6iycHc4A+hPVWj m4qHbGS/+LmlTFQ4o979BQrn+D04dQgdUYwb6Gn7X5LXdccGfaxmAzP1EoWP6dssTfGF P1uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701882104; x=1702486904; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g43u5jjhfQO9PY3VWTnpZWIR/gdaK4dtnhkglk2X8mA=; b=DoBVu3nJlnHVDs5P/RAb4ErNTeTf78UQJ/o7biyi098p8UqR2hlE1/dP3j715lvWFH +TiqtIv1yWTpw+zGFjYQssUsd9zdf19qwWapO5ZJCjKOxhXdyZI9VuWzStK+i3JcVD0M PbaikVBOA3bw5QxD0Ro/67f1WiQitNJUmbvNMZjjgXV/TGmUqaGE6VUb+khr3aue8Neb p07WahRFZg6+RSdOzgA25QYA0bBOKnSzSdeS9e7G2/qudDBPaefOfybPEZUDNiVf8Eb1 9NEok46GlZQLY6oR5zEUoRVfMRkkk0NP1WuFIz3cWM1+GQHICuz9LpBEyezblWown3Gk jp2g== X-Gm-Message-State: AOJu0YwGPdlvbPmb0vBKJL7uQfhlmEu4zNbq/MNGRYDMzeLZyC7DQCxh 1UFHANOmnC0aJgPoac33kuC+fg== X-Google-Smtp-Source: AGHT+IFgOhyYc5YRm3GuI/EjzMHKDir+CP6lbgO0ZmZB/99Bn5mK9Q+kbi86Ey7jhBkmSix8YSvbcw== X-Received: by 2002:a6b:a16:0:b0:7b6:ed55:37a with SMTP id z22-20020a6b0a16000000b007b6ed55037amr209095ioi.28.1701882104427; Wed, 06 Dec 2023 09:01:44 -0800 (PST) Received: from murgatroyd (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id w18-20020a029692000000b0045c1fcf2ef7sm44959jai.37.2023.12.06.09.01.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 09:01:43 -0800 (PST) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] Improve Ada name lookup performance References: <20231121-ada-lookup-perf-v1-0-1efd2d1dbf65@adacore.com> X-Attribution: Tom Date: Wed, 06 Dec 2023 10:01:42 -0700 In-Reply-To: <20231121-ada-lookup-perf-v1-0-1efd2d1dbf65@adacore.com> (Tom Tromey's message of "Tue, 21 Nov 2023 14:09:24 -0700") Message-ID: <8734wfjmdl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> This series started when a user noticed that gdb was very slow to Tom> print Ada records in a large program. I tracked this down and fixed Tom> it in patch #1. However, then I noticed that, with a little work, an Tom> entire method could be removed from quick_symbol_functions. This is Tom> desirable because this method was only used by Ada. Tom> I regression tested this on x86-64 Fedora 38. I also used regression Tom> tested using the .debug_names and .gdb_index target boards. It's also Tom> been run through the AdaCore internal test suite. I rebased this today and I think it needs a little work. It regressed gdb.dap/pause.exp, and then when looking at that I wondered what would happen if an inferior call caused an unexpected stop... so I think it may need another new test as well. Tom