From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/python: display errors from command completion
Date: Tue, 28 Nov 2023 08:23:35 -0700 [thread overview]
Message-ID: <8734wpewaw.fsf@tromey.com> (raw)
In-Reply-To: <66d012a42add48d890d0504b95c9f3a6daa37042.1701169440.git.aburgess@redhat.com> (Andrew Burgess's message of "Tue, 28 Nov 2023 11:04:53 +0000")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> This commit makes the gdb.Command.complete methods more verbose when
Andrew> it comes to error handling.
Thank you for doing this.
Andrew> + gdbpy_print_stack_or_quit ();
Hah, I didn't know about this one.
Some overlap with gdbpy_handle_exception here.
Anyway, this looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-11-28 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 11:04 Andrew Burgess
2023-11-28 15:23 ` Tom Tromey [this message]
2023-11-28 18:30 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734wpewaw.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).