From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 540CF3858C2D for ; Mon, 27 Nov 2023 19:02:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 540CF3858C2D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 540CF3858C2D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701111721; cv=none; b=w7nfHhtd3MZI+QiOZd5uKrfLQZNtEuX7UpVDOtYwjfQqwiTIp84QTkPvhoev+gJUm6skY1wk+41uu942tYr1SSZbMKG9+DxK3GFTOhuVsBeIl9PHn0Tcn1jnfq/YPp4Dq3YOusOB3PZJtJWRP48oGWOYwaCAVwBch1S6mhQO7Dc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701111721; c=relaxed/simple; bh=jxhDiJQ0Gqhx55RHO28pGlKozYxymnczgciruWILEdg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=IL5WkqbQePwFBQ+xYv3EvdHJfbBEVfU7OovNF3RYC6EiRewGJ9HXVlrYZo0t7ps3+tYDs2PJnDGNFLjwqO+EXUhXQi7QsPO/WFpX5daIfFNtJGY7upB3B2not88oEaZXl5oSBq/oBSqQ5vmkrhrBCk+KZy0MXJ3x6AZ+DJAxk/c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTPS id 7eyUrCporhqFd7grnrc27m; Mon, 27 Nov 2023 19:01:59 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 7grmrmcx0b8Qn7grmrd1n1; Mon, 27 Nov 2023 19:01:58 +0000 X-Authority-Analysis: v=2.4 cv=IuQNzZzg c=1 sm=1 tr=0 ts=6564e7a6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=BKrjXSNHqnxK1Cv0Rk4A:9 a=zZCYzV9kfG8A:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gj+PSohaSoB1zh7RjGA8R3cgrtogn/7MAA821ldNpKU=; b=xXb1eBAnIABw0U0utKEXYsv0aw wTu+98LbyuUw+Wdgxqah6mwDIdSdofSkfTbrmUFhI/ij7voSHyTSaHbkwrh68YA6u/d9yH9mzWCQJ w7xMgRDIFZJW8VxUj5e7l5r3F; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:41752 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r7grm-000Nuz-0O; Mon, 27 Nov 2023 12:01:58 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/7] gdb: C++-ify mapped_symtab from dwarf2/index-write.c References: X-Attribution: Tom Date: Mon, 27 Nov 2023 12:01:57 -0700 In-Reply-To: (Andrew Burgess's message of "Mon, 27 Nov 2023 17:55:59 +0000") Message-ID: <8734wrf2ai.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r7grm-000Nuz-0O X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (murgatroyd) [97.122.77.73]:41752 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHQYL0oP5/8yXuCVa8j8SybO5wMU3AtTUwhV0/WCpQH5ktcRb4GJsxwvOUvhhrViUCFcHqJ8Lr/jOMOld3EYbLKMVzyxItuDE+U5wRownxrnEVIYHq8Q +dPknVMwcx1gzk5hlx35a7Tltuv9AkLPWHbL0jZZ/uNqP8ZksBbrlnfZwONJN35G6js4eGYPJ0bgU/dUr/8CRORxjVv8JFpBVrw= X-Spam-Status: No, score=-3017.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> mapped_symtab class can be treated like a contained and iterated s/contained/container Andrew> + /* Access the obstack. */ Andrew> + auto_obstack *obstack () A real nit, but it is probably better to just return 'struct obstack *' here. Returning an auto_obstack makes it seem like the special auto- behavior is important somewhere, but it isn't and/or shouldn't be. Tom