Re: [PATCHv2 1/2] Implement locals TUI window

[Tom Tromey <tom@tromey.com>]

>>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:

I'm sorry about the extreme delay on this.

Hannes> gdb/ChangeLog:
Hannes> 2021-06-04  Hannes Domani  <ssbssa@yahoo.de>

Hannes> 	PR tui/17849
Hannes> 	* data-directory/Makefile.in: Add tui_windows.py.
Hannes> 	* python/lib/gdb/command/tui_windows.py: New file.

I recently became aware there was a v2 of this patch.  I must have
missed it when you originally sent it.

Hannes> +PY3 = sys.version_info[0] == 3
Hannes> +
Hannes> +if PY3:
Hannes> +    basestring = str

Can drop this now.

Hannes> +def val_cmp_color(prev, cur, sym_not_init, argument, empty=False):
Hannes> +    """Returns the color escape sequences for variable name and value."""
Hannes> +    var_col_s, var_col_e, val_col_s, val_col_e = "", "", "", ""
Hannes> +    if empty:
Hannes> +        # Variable without contents
Hannes> +        var_col_s, var_col_e = "\033[1;30m", "\033[0m"
Hannes> +    elif prev is None:
Hannes> +        # New variable
Hannes> +        var_col_s, var_col_e = "\033[1;32m", "\033[0m"
Hannes> +    elif prev != cur:
Hannes> +        # Variable contents changed
Hannes> +        val_col_s, val_col_e = "\033[1;31m", "\033[0m"
Hannes> +    if argument:
Hannes> +        # Variable is a function argument
Hannes> +        var_col_s, var_col_e = "\033[1;35m", "\033[0m"
Hannes> +    elif sym_not_init:
Hannes> +        # Variable was not yet initialized
Hannes> +        var_col_s, var_col_e = "\033[33m", "\033[0m"
Hannes> +    return (var_col_s, var_col_e, val_col_s, val_col_e)

Perhaps these should have 'set style' parameters?
Or reuse existing ones?

Hannes> +def is_string_element_type(t):
Hannes> +    """Return if an array of this type is considered a string."""
Hannes> +    target_type = t.target().strip_typedefs()
Hannes> +    return target_type.code == gdb.TYPE_CODE_INT and (
Hannes> +        target_type.name == "char" or is_typedef_of(t.target(), "wchar_t")
Hannes> +    )

There's a more direct way of doing some of this stuff now.
This code can probably reuse the work done for DAP.

Hannes> +class ArrayPrinter(object):
Hannes> +    """Pretty printer for arrays."""

Same for this and the other "no-op" printers.

Hannes> +class StructPrinter(object):
...
Hannes> +        for f in fields:
Hannes> +            if not hasattr(f, "bitpos"):
Hannes> +                continue

Oops, I think this points out a bug in NoOpStructPrinter.
I'll fix that.

Hannes> +            # Disable dynamic_type for base classes, to prevent infinite
Hannes> +            # recursion.
Hannes> +            if child_v.type.code == gdb.TYPE_CODE_STRUCT and f.is_base_class:
Hannes> +                pp = None
Hannes> +                if not self.raw:

Hmm I wonder if this is one as well.

Hannes> +                                if key is not None:
Hannes> +                                    self.add_val(
Hannes> +                                        "[" + str(key) + "]",
Hannes> +                                        fnc,
Hannes> +                                        vc,
Hannes> +                                        inset + 1,
Hannes> +                                        0,
Hannes> +                                        cur_vals,
Hannes> +                                        keep_prev,
Hannes> +                                        False,
Hannes> +                                        False,
Hannes> +                                        False,
Hannes> +                                        raw,
Hannes> +                                        fmt,
Hannes> +                                        None,
Hannes> +                                    )
Hannes> +                                else:
Hannes> +                                    self.add_val(
Hannes> +                                        "value",
Hannes> +                                        fnc,
Hannes> +                                        vc,
Hannes> +                                        inset + 1,
Hannes> +                                        0,
Hannes> +                                        cur_vals,
Hannes> +                                        keep_prev,
Hannes> +                                        False,
Hannes> +                                        False,
Hannes> +                                        False,
Hannes> +                                        raw,
Hannes> +                                        fmt,
Hannes> +                                        None,
Hannes> +                                    )

Some things like this could probably be simplified?

I found some of this code pretty hard to follow.

Tom