From: Tom Tromey <tom@tromey.com>
To: Guinevere Larsen <blarsen@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Move read_addrmap_from_aranges to new file
Date: Thu, 26 Oct 2023 16:58:15 -0600 [thread overview]
Message-ID: <8734xxuh2w.fsf@tromey.com> (raw)
In-Reply-To: <e16a3731-5655-4b9d-05b6-0252c82e8f7e@redhat.com> (Guinevere Larsen's message of "Thu, 26 Oct 2023 11:56:43 +0200")
>>>>> Guinevere Larsen <blarsen@redhat.com> writes:
> On 14/10/2023 22:56, Tom Tromey wrote:
>> In the interest of shrinking dwarf2/read.c a little more, this patch
>> moves the code that deciphers .debug_aranges into a new file.
> This is a good change, I just have a small question: why you only
> chose to move read_addrmap_from_aranges and not also move
> create_addrmap_from_aranges? I know the second function isn't in
> dwarf2/read.c, but I think it would make aranges.c more consistent.
create_addrmap_from_aranges is only used by read-debug-names.c, so it
seemed a little better to just leave it there as a static function.
Tom
next prev parent reply other threads:[~2023-10-26 22:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 20:56 [PATCH 0/2] Two .debug_aranges changes Tom Tromey
2023-10-14 20:56 ` [PATCH 1/2] Pre-read .debug_aranges section Tom Tromey
2023-10-26 9:54 ` Guinevere Larsen
2023-10-29 16:34 ` Tom Tromey
2023-10-14 20:56 ` [PATCH 2/2] Move read_addrmap_from_aranges to new file Tom Tromey
2023-10-26 9:56 ` Guinevere Larsen
2023-10-26 22:58 ` Tom Tromey [this message]
2023-10-27 7:27 ` Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734xxuh2w.fsf@tromey.com \
--to=tom@tromey.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).