From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 660BB3858D32 for ; Thu, 26 Oct 2023 22:58:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 660BB3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 660BB3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698361096; cv=none; b=Ytpz45UYCeaPpPO3udo5dmbAVqeFnBVn8W58DoN44nN7tNDKyscQ0wa+nKQ4GMNdkHGexYux8jvr7FeQWb1Wju0t2ZEwlk98sLwnOqXMQAsB+S4sglYKH//yROSleBm5k499CbsVn/ej15Yf/dw+SpbBLwVwClBt2Jy0Fs3sTUs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698361096; c=relaxed/simple; bh=AM85QgEfFPiHJHfsviPHhwBgPnNtSygGdOmtUpniF/k=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Fs8tUuUMWsS8fAynl5/QBPQ93m/SNDQnjveNyXrZ2aBv9vXlGlaGOcd68JBS2lzSdGhvgfgyDdlRa8EO7j067OvfEPkakS2drutvS5nLvb16IW00pfBF4IrvKlSrIyzHdM2lPY3J4SHvo/yIXPz4C8F2UXVu2YPRsStKnXCUHBw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5008a.ext.cloudfilter.net ([10.0.29.246]) by cmsmtp with ESMTPS id vy5rqomiUhqFdw9IrqI9uV; Thu, 26 Oct 2023 22:58:13 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id w9IqqoqClpPpmw9Iqqo6Ne; Thu, 26 Oct 2023 22:58:12 +0000 X-Authority-Analysis: v=2.4 cv=MJVzJeVl c=1 sm=1 tr=0 ts=653aef04 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=_LVMZQ73Otiy_qurxPkA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AM85QgEfFPiHJHfsviPHhwBgPnNtSygGdOmtUpniF/k=; b=SvA/gNMWH1/E1Wo5ZV1mlkpeYl /o7JeaIc2mK4bzQj200tT+iI534DERdONtd0ogwaHrLWg0fhEl3vA4CYB0YzkB8qdD+WC2QwhO2YS +0sguBv2k6IXPW/yGcS3WD3Ie; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:46242 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1qw9Ip-002P5K-2d; Thu, 26 Oct 2023 16:58:11 -0600 From: Tom Tromey To: Guinevere Larsen Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Move read_addrmap_from_aranges to new file References: <20231014205755.996771-1-tom@tromey.com> <20231014205755.996771-3-tom@tromey.com> X-Attribution: Tom Date: Thu, 26 Oct 2023 16:58:15 -0600 In-Reply-To: (Guinevere Larsen's message of "Thu, 26 Oct 2023 11:56:43 +0200") Message-ID: <8734xxuh2w.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1qw9Ip-002P5K-2d X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (prentzel) [97.122.77.73]:46242 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJXFOZlwm8+FbsMbsqzANL9ARa85WxRCjPaShIE2KcUnmhWFPk+FmxA3zOXiSvD4n9KgADVCD2XpVSRO9dsEWHbfmGZUe8WVe9AfbBQmtGA/wtxDPZMN JlktDdamI2wmjZh1KYV1v2zcy44ODAAFQnexDq+5VBRQr7I8AiM0i6d/BXteAqUngEwIl5lFlRWXMipXEuvdARUTQ7NdHIgFT6M= X-Spam-Status: No, score=-3018.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Guinevere Larsen writes: > On 14/10/2023 22:56, Tom Tromey wrote: >> In the interest of shrinking dwarf2/read.c a little more, this patch >> moves the code that deciphers .debug_aranges into a new file. > This is a good change, I just have a small question: why you only > chose to move read_addrmap_from_aranges and not also move > create_addrmap_from_aranges? I know the second function isn't in > dwarf2/read.c, but I think it would make aranges.c more consistent. create_addrmap_from_aranges is only used by read-debug-names.c, so it seemed a little better to just leave it there as a static function. Tom