From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 85A6A3858D20 for ; Fri, 20 Oct 2023 19:50:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 85A6A3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 85A6A3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697831445; cv=none; b=gMzu5Up4loSiGbtB16XoymnDQxjAHlVBHRpugm35uctD9u9RCreJD0wfiiSWbvA07+F1PPVb1EFK2bTbAlt4WvuoLoM9vFzChVBvs+nm9Zse99pnFrTza/Az3F4c1EBOxlBxqJp24JsHrPeLnrCBBFvuqY+okaMqlfhw7zLijE0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697831445; c=relaxed/simple; bh=Cu3rci6x9SeG7QlaiCcwidJQc2V/6mvRLTjP4x1XiXA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=adz2etT2bC5ey2ofFijFTWKRmHfhxz8cMeb0jtf1knQ+lXW0gzk2UBAc49DeiQMFaSaUPld8eyeYsBMHeQvZtp4Z/95UsKaAjUfU08dsvBMaEGB08VHpCCG/hCXYUjE/qrdgCH03yAYgKXlZ8vgxFhlr+ViBkqw0aBqzKZr8quI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6003a.ext.cloudfilter.net ([10.0.30.151]) by cmsmtp with ESMTPS id tlCjqWeiF6nOZtvW7qpuq4; Fri, 20 Oct 2023 19:50:43 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id tvW6q22fyRqxCtvW6qRZAm; Fri, 20 Oct 2023 19:50:42 +0000 X-Authority-Analysis: v=2.4 cv=IY2U5Ema c=1 sm=1 tr=0 ts=6532da12 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yV3DDFZqlfoE2LauPGLsmB8dv1g/EZ1VJZ4BroDKhtI=; b=K5WsJUHllNIaQ0wsKEWEks6ElO RmLv9Ebfx8Oaz5nf+M6m8vDjkDiyBoem2dmR+cx1o9vliZF/ZggyCLanRtZLJ6Zloo4BXGuT9UqGG Qs9WQ4AdXfKEiqSD6HANF4BgM; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:56874 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1qtvW5-002hX0-2G; Fri, 20 Oct 2023 13:50:41 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH 01/13] [gdb/symtab] Factor out m_die_range_map usage References: <20231002125051.29911-1-tdevries@suse.de> <20231002125051.29911-2-tdevries@suse.de> X-Attribution: Tom Date: Fri, 20 Oct 2023 13:50:40 -0600 In-Reply-To: <20231002125051.29911-2-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Mon, 2 Oct 2023 14:50:39 +0200") Message-ID: <8734y5oyy7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1qtvW5-002hX0-2G X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (murgatroyd) [97.122.77.73]:56874 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfIKcSLk8a1/55Nlae4WHtSam8Dryropo/6yL56SpdiRx6vqsg+uwUc3lplNXPY3JClc2v6ltosfdJD3DqEpuzs74hlAEIt4fp0XICTqHGprqckzZcJ2A +dKBGejZDtVRMg0ovOD5VPNiox5KtCu2D089xQ1XdjKGYBZZaJq/4Ird0jFHPwQAry2gl87SNxpyNyFoHLjSyuu2nsy8FpZgnww= X-Spam-Status: No, score=-3018.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> Factor out usage of cooked_indexer::m_die_range_map into new class parent_map Tom> with member functions find_parent and set_parent. Tom> + /* Find the parent of DIE LOOKUP. */ Tom> + const cooked_index_entry *find_parent (CORE_ADDR lookup) const Tom> + { I sort of regret doing this stuff using CORE_ADDR. I think the API would be better if 'form_addr' was handled privately in the wrapper class. Tom