From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH v2] [gdb/build] Work around cgen odr violations
Date: Tue, 22 Aug 2023 09:48:02 -0600 [thread overview]
Message-ID: <87350bw025.fsf@tromey.com> (raw)
In-Reply-To: <20230821054707.6558-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Mon, 21 Aug 2023 07:47:07 +0200")
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> Fix this by making the conflicting type names unique, adding a target-specific
Tom> prefix using a define before the include:
Tom> ...
Tom> #define cgen_operand_type <target-name>_cgen_operand_type
Tom> #define cgen_hw_type <target-name>_cgen_hw_type
Tom> #include "opcodes/<target-name>-desc.h"
Tom> ...
Tom> and move those defines into a new file cgen-remap.h, similar to how that's
Tom> done for yacc in yy-remap.h.
Looks good, thanks.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2023-08-22 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 5:47 Tom de Vries
2023-08-22 15:48 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87350bw025.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).