From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 1EADE3858C5F for ; Fri, 4 Aug 2023 16:31:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1EADE3858C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 3EB1D100471A4 for ; Fri, 4 Aug 2023 16:31:00 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id RxhcqvHWVIkmWRxhcqps3d; Fri, 04 Aug 2023 16:31:00 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=S/wcfKgP c=1 sm=1 tr=0 ts=64cd27c4 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=6I5d2MoRAAAA:8 a=V59Nd7PJQ_jE01fIV5MA:9 a=zgiPjhLxNE0A:10:nop_mobile_phish_fin_what a=IjZwj45LgO3ly-622nXo:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1cFcM5TlDrJXKTTi4xQ+2/eXCX3s2iMVl4fFy7XQTYY=; b=GgxlIKBMcu3FM1Sff7qliR9cix 4wC1WGqWiowmm5p76oYslURl0gWBygP+hWARRx6YRfF9Ulq1VV7E4MOx+PKXh8DNw0ROQDN/uhIxV LwIBRHKkhG4/wiJkwnI/2i1kI; Received: from 71-211-152-221.hlrn.qwest.net ([71.211.152.221]:44470 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qRxhb-0020Id-38; Fri, 04 Aug 2023 10:31:00 -0600 From: Tom Tromey To: John Baldwin Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 3/8] fbsd-nat: Fix resuming and waiting with multiple processes. References: <20230717192039.13976-1-jhb@FreeBSD.org> <20230717192039.13976-4-jhb@FreeBSD.org> X-Attribution: Tom Date: Fri, 04 Aug 2023 10:30:59 -0600 In-Reply-To: <20230717192039.13976-4-jhb@FreeBSD.org> (John Baldwin's message of "Mon, 17 Jul 2023 12:20:34 -0700") Message-ID: <87350ybwho.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.152.221 X-Source-L: No X-Exim-ID: 1qRxhb-0020Id-38 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-152-221.hlrn.qwest.net (murgatroyd) [71.211.152.221]:44470 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "John" == John Baldwin writes: John> +/* Information stored about each inferior. */ John> +struct fbsd_inferior_info John> +{ John> + /* Filter for resumed LWPs which can report events from wait. */ John> + ptid_t resumed_lwps = null_ptid; John> + John> + /* Number of LWPs this process contains. */ John> + unsigned int num_lwps = 0; John> + John> + /* Number of LWPs currently running. */ John> + unsigned int running_lwps = 0; John> + John> + /* Have a pending SIGSTOP event that needs to be discarded. */ John> + bool pending_sigstop = false; John> +}; John> + John> +/* Per-inferior data key. */ John> + John> +static const registry::key fbsd_inferior_data; It isn't obvious from the comment (something we ought to fix), but I think the inferior::priv field is reserved for the process stratum target to use. So, you don't need a registry key, you can just derive fbsd_inferior_info from 'private_inferior'. Tom