From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id 0798A3858D20 for ; Wed, 2 Aug 2023 19:44:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0798A3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12c.google.com with SMTP id e9e14a558f8ab-34914684b62so732795ab.3 for ; Wed, 02 Aug 2023 12:44:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1691005468; x=1691610268; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ws2aXaKh9NDXzrlGuoTmTd16mEiROZQiHEuCS4EFes8=; b=XslAbHomc/m8lLSNo829G04Ljr3ZwHRxjXws9bG8kbi4ACruvzEeS2yMAEXmOk0Er0 B5ugbSozWhuFC9louATeP7M+WXMsXfwSoddIe4ZXyDpn5bsDCJSIVynU1Jo+bpVUE5VM QdExN07cQQNRPpbqeaycdjP3QbN6JfkyWt7H6ud0S4BVT7Si2wZrE/9+aarF/kWCgGKD gct/ym4RabP1s3kvwe9GMXk3jM3qGVfKyH6/iSOvMr9DDAsoxX2PN+CiovZw+HcEwWcs qbPQG8rTI2GvqIOaM0zNQXawF+xavydeM1aywTK/b1HcP+3jzAjelb6fEBZGLr59S2bk LLag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691005468; x=1691610268; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ws2aXaKh9NDXzrlGuoTmTd16mEiROZQiHEuCS4EFes8=; b=NDp0JzWQhsSCKR+xFL0vl3F04JYr+ionnsjgrtJQeZ+JBWllPhy5+p8uFw8TtjoVNb PT9aCK1XJTOrLKLP69q1K+IIWN+Yj5RwCkEYfppvPflH1inlFRyLxH+kJY8W2En92v27 YMibthkBRqwZjlJD3dC2Fz1gTWByr4NmZYH5a72GhNa6AUdI20Dq3vwhlQzCFi019Qf4 PyjQBB7EFLnOpadBMtu11xhUTe7/gu+cWCy8SU5FljbDteTQK4IgcTkzzuu2OZ96XU31 0wPHdJlEgMwseEKk3ebjGrc20Ls5Ghu93Ov+jz4QhG/m//sP9TXcqI5pHzqABubYCRik znIA== X-Gm-Message-State: ABy/qLb6b+tm+qeLOUCf9V1xChcf9AOJaTb9AkIdYmvuOHe0YpqULxno rWXwwPGf1zbCQax09d6nI0DKU2QVqD805LnWRNFeAg== X-Google-Smtp-Source: APBJJlHM6ngI96LWz7HQx4NY2UEduizIWaVDEvK/byHqs3b8xJHG3/S95iY4JHdzmhnF3URKR9mviQ== X-Received: by 2002:a05:6e02:1050:b0:348:8b42:3ae9 with SMTP id p16-20020a056e02105000b003488b423ae9mr13549326ilj.13.1691005468303; Wed, 02 Aug 2023 12:44:28 -0700 (PDT) Received: from murgatroyd (75-166-148-59.hlrn.qwest.net. [75.166.148.59]) by smtp.gmail.com with ESMTPSA id f17-20020a92cb51000000b00342093347d8sm4676042ilq.76.2023.08.02.12.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 12:44:27 -0700 (PDT) From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH v2 0/6] [gdb/symtab] Fix data-races in gdb.base/index-cache.exp References: <20230802095305.3668-1-tdevries@suse.de> X-Attribution: Tom Date: Wed, 02 Aug 2023 13:44:27 -0600 In-Reply-To: <20230802095305.3668-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Wed, 2 Aug 2023 11:52:59 +0200") Message-ID: <873511dyas.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Thanks for this series. I read through it and sent a few notes. Tom> There's one more patch like that, I checked using pahole that the struct size Tom> is not increased. "ptype/o" is basically pahole FWIW. I tend to think that in most cases, the size of objects doesn't really matter. I mean, obviously we don't want to bloat them unnecessarily, but for something like this, I just wouldn't worry much... and if we did care there's probably some other way we could shrink them than worrying about packing. In the olden days pretty much the only thing really worth worrying about was partial symbols. Now I guess it would be cooked_index_entry. Tom