From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 58E8E3858CDA for ; Thu, 27 Jul 2023 22:25:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58E8E3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-6b9b52724ccso1241055a34.1 for ; Thu, 27 Jul 2023 15:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690496726; x=1691101526; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=zAz8nhgkNGk6Zlp/oz0lHXKFCBwsZwBpVy5v/GYmkPc=; b=LslgFckq0VBsKtST7T64HrLWOl/Hiu9lCIInyGfPmtzaTp4XGPa59PlrCwlbcBY+9f 6JW9XNR9jg4WGLsnzE74mzCWlI0bEXp3BQbCGSggtWynhu9fG/psrxYd34fkUCPFncRv K1Umh4givI6DFDZ/zB2byGL3bnR8NrWhC0ZqyWbEznwXatfV0oDylxVGUZ88BWPn1+Hh AaNkhWJdFHWJ59HFU7ZTBVBlraSQSdnOZTWJ/IKS28h2wlHb0dnHLZSd6shVAQ/BzWx0 6c9TZQqt/nt0gpoaqgt+YMwE5ghcTfWEzGVxeKi03duqs01wesk1WN8zBhjU0+nYYPbl uhcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690496726; x=1691101526; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zAz8nhgkNGk6Zlp/oz0lHXKFCBwsZwBpVy5v/GYmkPc=; b=AgHyEZitmeJd21ftOeXmE+98ZIfyV1YiMYu1+ODBDm3tIITXH7qu+ekZXnTbXOmc6N aA9MUWnsOrPmTT0h+X7BqoTUJXRZpd17AQEXK7b072br6CPFLMod3uGqeoSG9nLC3zL8 13AKQIz8CH7zgnjtgEDMoCdPu0BZYC1/B7aTZKnyekrQeVnipvEcacOSZT/b+eQV21e7 dNf5WSgje147xugSOsskQRDMVyxfR8QYNysB6C4qeRU6nonm9SsLmSoPc6ZIJ90QQVaM 6lTJ0UouliElGA9iopkyF/EB8J2PooHx4IDlf8RctSZVrxca80YIrQb64DshoNiQ5D+1 4osA== X-Gm-Message-State: ABy/qLbR7oO//TiQ6ZfQvXbsqyiGIZMXrKn9Tfm6F+L5c+MIV3XOfj0x BYob/pzleUlSpNv1SjPYRocC962tB03c0GcAHzM= X-Google-Smtp-Source: APBJJlEVwfbcAExbFsBh7z8S4hOm+vTqzeesMZZrcq7ZHOq6VUX6Vy7rYlo6/ylSIrU5vOihincVKA== X-Received: by 2002:a05:6870:c891:b0:1bb:4d4e:ea69 with SMTP id er17-20020a056870c89100b001bb4d4eea69mr785635oab.54.1690496726710; Thu, 27 Jul 2023 15:25:26 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:b6b2:cb77:8e91:bbbd]) by smtp.gmail.com with ESMTPSA id y136-20020a4a458e000000b0051134f333d3sm1081692ooa.16.2023.07.27.15.25.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 15:25:26 -0700 (PDT) References: <20230630134616.1238105-1-luis.machado@arm.com> <20230630134616.1238105-10-luis.machado@arm.com> User-agent: mu4e 1.10.5; emacs 28.2 From: Thiago Jung Bauermann To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 09/16] [gdb/aarch64] sme: Signal frame support In-reply-to: <20230630134616.1238105-10-luis.machado@arm.com> Date: Thu, 27 Jul 2023 19:25:23 -0300 Message-ID: <8735198018.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Luis Machado via Gdb-patches writes: > @@ -385,6 +414,38 @@ aarch64_linux_sigframe_init (const struct tramp_frame *self, > break; > } > > + case AARCH64_ZA_MAGIC: > + { > + if (!tdep->has_sme ()) > + { > + section += size; > + break; > + } > + > + /* Check if the section is followed by a full ZA dump, and set > + za_state if it is. */ > + gdb_byte buf[2]; > + > + if (target_read_memory (section + AARCH64_SVE_CONTEXT_VL_OFFSET, Shouldn't this line use AARCH64_SME_CONTEXT_SVL_OFFSET? It has the same value as AARCH64_SVE_CONTEXT_VL_OFFSET so in practice there's no difference, but conceptually it's less confusing. -- Thiago