From: Tom Tromey <tom@tromey.com>
To: Simon Farre via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Farre <simon.farre.cx@gmail.com>, tom@tromey.com
Subject: Re: [PATCH v2] gdb/DAP Few bug fixes & Evaluate Array Watch vars
Date: Thu, 22 Jun 2023 08:06:01 -0600 [thread overview]
Message-ID: <87352j383a.fsf@tromey.com> (raw)
In-Reply-To: <20230622130215.126932-1-simon.farre.cx@gmail.com> (Simon Farre via Gdb-patches's message of "Thu, 22 Jun 2023 15:02:15 +0200")
>>>>> "Simon" == Simon Farre via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> EvaluateResult does not need a name, just as what Tom pointed out in
Simon> previous review. It's only the *children* that need to be made sure that
Simon> their names are valid. An identifier for a variable, can't ever have an
Simon> integer as a name, anyhow (not as far as I am aware, no programming
Simon> languages allow for that).
FWIW Rust uses them as tuple field names, but in gdb I think they'd wind
up as string regardless.
Thanks for the patch, this is ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2023-06-22 14:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 13:02 Simon Farre
2023-06-22 14:06 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87352j383a.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.farre.cx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).