From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 1CBCA3850218 for ; Mon, 5 Jun 2023 13:45:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1CBCA3850218 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 5AE631003B6E9 for ; Mon, 5 Jun 2023 13:45:57 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 6AWzq96C9mjMl6AWzqNrPr; Mon, 05 Jun 2023 13:45:57 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=KfEXDSUD c=1 sm=1 tr=0 ts=647de715 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=of4jigFt-DYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=12HJxPMDJjWy6E639wwA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GamREFzQ0k/Uy6yDZzhM4AH6J2kB/1jmAdLBJBPs8Do=; b=SM6G8gTuS+9Q/gjb7w6OzvQH3o HZ2RpcQoyXUtPxqN0Ddio8X9Q2icehRUz7cKUi7Hrij/knXumuwgi64JK0jX2Rtx4BnoUZeT25N5K I5nId+wTVjWqBivNYsSoSO21P; Received: from 71-211-130-244.hlrn.qwest.net ([71.211.130.244]:49470 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q6AWy-002kly-1f; Mon, 05 Jun 2023 07:45:56 -0600 From: Tom Tromey To: Simon Farre via Gdb-patches Cc: Simon Farre Subject: Re: [PATCH v5] gdb/Python: Added ThreadExitedEvent References: <20230605114151.61322-1-simon.farre.cx@gmail.com> X-Attribution: Tom Date: Mon, 05 Jun 2023 07:45:55 -0600 In-Reply-To: <20230605114151.61322-1-simon.farre.cx@gmail.com> (Simon Farre via Gdb-patches's message of "Mon, 5 Jun 2023 13:41:51 +0200") Message-ID: <873536t430.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.244 X-Source-L: No X-Exim-ID: 1q6AWy-002kly-1f X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-244.hlrn.qwest.net (murgatroyd) [71.211.130.244]:49470 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Farre via Gdb-patches writes: Thank you for the patch. It looks good to me, but I have a few nits. Simon> +/* Emits a thread exit event for THREAD containing the attributes Simon> + global_num, name, num and ptid */ Simon> +extern int emit_thread_exit_event (thread_info * thread); This comment needs an update. Simon> + Simon> +/* Emits a thread exit event for THREAD containing the attributes Simon> + global_num, name, num and ptid */ Here too but it could just refer to the other one. Simon> diff --git a/gdb/testsuite/gdb.python/py-thread-exited.exp b/gdb/testsuite/gdb.python/py-thread-exited.exp Simon> new file mode 100644 Simon> index 00000000000..ec552fc8b6e Simon> --- /dev/null Simon> +++ b/gdb/testsuite/gdb.python/py-thread-exited.exp Simon> +if { ![support_displaced_stepping] } { Simon> + unsupported "displaced stepping" Simon> + return -1 Simon> +} I suspect this check isn't needed, since I don't think this test uses displaced stepping. Simon> +save_vars { GDBFLAGS } { Simon> + clean_restart $testfile Simon> +} Probably the save_vars isn't needed either, since GDBFLAGS isn't modified in the body. Simon> diff --git a/gdb/testsuite/gdb.python/py-thread-exited.py b/gdb/testsuite/gdb.python/py-thread-exited.py Simon> new file mode 100644 Simon> index 00000000000..51dfeb05ae4 Simon> --- /dev/null Simon> +++ b/gdb/testsuite/gdb.python/py-thread-exited.py Simon> @@ -0,0 +1,31 @@ Simon> +import gdb New files should have a copyright header. Tom